Page MenuHomePhabricator

Make RuboCop job voting
Closed, ResolvedPublic

Description

The only thing left to do with RuboCop is to make it voting for all repositories that it runs for.

Event Timeline

zeljkofilipin raised the priority of this task from to Medium.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin changed Security from none to None.

For mediawiki-core, the test should not be voting for the old release branch unless we fix rubocop in them as well (unlikely). In Zuul that can be done with:

jobs:
 - mediawiki-core-bundle-rubocop
    branch: ^(REL1_21|REL1_22|REL1_23|REL1_24)$

That will prevent the job from running on those release branches, but still make it run on master (and future REL branches such as REL1_25).

+1. Can you do Cirrus first? I had it clean and then kept hacking a while back and didn't notice that I broke it again. I'm going to add a patch that should get it passing again but without it voting I'm liable to forget again.

Change 191861 had a related patch set uploaded (by Zfilipin):
Make RuboCop jobs voting

https://gerrit.wikimedia.org/r/191861

Patch-For-Review

Change 191861 merged by jenkins-bot:
Make RuboCop jobs voting

https://gerrit.wikimedia.org/r/191861

Deployed successfully. Zeljkof is going to send the announce about rubocop jobs being voting from now on.