The only thing left to do with RuboCop is to make it voting for all repositories that it runs for.
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| integration/config | master | +0 -43 | Make RuboCop jobs voting |
Related Objects
Related Objects
- Mentioned In
- rCICFab39cd38a71e: Make RuboCop jobs voting
Event Timeline
Comment Actions
For mediawiki-core, the test should not be voting for the old release branch unless we fix rubocop in them as well (unlikely). In Zuul that can be done with:
jobs: - mediawiki-core-bundle-rubocop branch: ^(REL1_21|REL1_22|REL1_23|REL1_24)$
That will prevent the job from running on those release branches, but still make it run on master (and future REL branches such as REL1_25).
Comment Actions
+1. Can you do Cirrus first? I had it clean and then kept hacking a while back and didn't notice that I broke it again. I'm going to add a patch that should get it passing again but without it voting I'm liable to forget again.
Comment Actions
Change 191861 had a related patch set uploaded (by Zfilipin):
Make RuboCop jobs voting
Comment Actions
Deployed successfully. Zeljkof is going to send the announce about rubocop jobs being voting from now on.