Page MenuHomePhabricator

Examples surrounded by visible p tags
Closed, ResolvedPublic

Description

When clicking on examples for any of the modules in the APISandbox the examples are surrounded by visible <p>-tags. (see screenshot)

Screenshot_from_2014-12-19_14:40:13.png (574×1 px, 74 KB)

Event Timeline

Lokal_Profil raised the priority of this task from to Needs Triage.
Lokal_Profil updated the task description. (Show Details)
Lokal_Profil changed Security from none to None.
Lokal_Profil subscribed.
gerritbot subscribed.

Change 188793 had a related patch set uploaded (by Amire80):
Remove <p> tags from API examples

https://gerrit.wikimedia.org/r/188793

Patch-For-Review

I attempted to fix this in https://gerrit.wikimedia.org/r/188793 , though it's probably not perfect. I don't quite understand where is the link supposed to point. Also, manual removing of HTML on the frontend looks suboptimal to me, and maybe the API can provide something better form the start, but that would have to be done in core, so @Anomie may want to chime in about that.

Yeah, the <p> tags probably should be adjusted in core. But there's other HTML coming out in some of the messages too that won't be adjusted in core.

Although what really needs to happen is that I need to find time to rewrite ApiSandbox, to handle stuff like this better and to handle action=flow.

Change 193148 had a related patch set uploaded (by Anomie):
API: paraminfo html strings shouldn't include unnecessary <p>s

https://gerrit.wikimedia.org/r/193148

Change 193162 had a related patch set uploaded (by Umherirrender):
Handle examples as raw html on Special:ApiSandbox

https://gerrit.wikimedia.org/r/193162

Change 188793 abandoned by Amire80:
Remove <p> tags from API examples

Reason:
Fixed in core.

https://gerrit.wikimedia.org/r/188793

Change 193162 merged by jenkins-bot:
Handle examples as raw html on Special:ApiSandbox

https://gerrit.wikimedia.org/r/193162

Change 193148 merged by jenkins-bot:
API: paraminfo html strings shouldn't include unnecessary <p>s

https://gerrit.wikimedia.org/r/193148

Umherirrender claimed this task.

Fix will be part of Version 1.25wmf20 - see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the timeline