Page MenuHomePhabricator

Three notifications are sent for one thing (dependency)
Closed, InvalidPublic

Description

bawolff created this task.
bawolff assigned this task to aklapper.
bawolff added subscribers: qgil, ragesoss, bd808, aude, gpaumier, jdforrester, scfc, Nemo_bis.
bawolff added a project: Wikimedia Phabricator

TASK DESCRIPTION

We should verify that anti-vandalism tools are available. Ideally we would be able to get rid of the notion of "editbugs" that we use in bugzilla

TASK DETAIL

http://fab.wmflabs.org/T146

To: aklapper, bawolff
Cc: qgil, ragesoss, bd808, aude, gpaumier, jdforrester, scfc, Nemo_bis


bawolff added a dependent task: T46: Identify features Bugzilla users would miss in Phabricator

TASK DETAIL

http://fab.wmflabs.org/T146

To: aklapper, bawolff
Cc: qgil, ragesoss, bd808, aude, gpaumier, jdforrester, scfc, Nemo_bis


bawolff added a dependency: T146: Make sure anti-vandalism features are up to snuff

TASK DETAIL

http://fab.wmflabs.org/T46

To: aklapper, bawolff
Cc: qgil, ragesoss, bd808, aude, gpaumier, jdforrester, scfc, Nemo_bis

Details

Reference
fl147

Event Timeline

flimport raised the priority of this task from to Medium.Sep 12 2014, 1:27 AM
flimport set Reference to fl147.

qgil wrote on 2014-04-17 21:38:07 (UTC)

Isn´t this consistent with your email preferences? How is this different from Bugzilla?

Nemo_bis wrote on 2014-04-18 06:39:07 (UTC)

No. Bugzilla never sends duplicates.

aklapper wrote on 2014-04-18 08:15:40 (UTC)

Bugzilla would also send at least two notifications for your example above, one for T46 blocking and one for T146 depending. Apart from that it's atomic - an action at a different time than another action creates a separate notification, so if you cannot add a dependent task at the same time than task creation, that's the outcome for notifications.

I consider the splitting of actions into separate notifications with the action mentioned in the email summary even a feature, as several changes don't get lost in the mail body.

scfc wrote on 2014-05-06 21:09:06 (UTC)

@Aklapper:

Bugzilla would also send at least two notifications for your example above, one for T46 blocking and one for T146 depending. Apart from that it's atomic - an action at a different time than another action creates a separate notification, so if you cannot add a dependent task at the same time than task creation, that's the outcome for notifications.

In Bugzilla if the edit is atomic, so is the notification; but:

I consider the splitting of actions into separate notifications with the action mentioned in the email summary even a feature, as several changes don't get lost in the mail body.

That's not what I see; random example: @Nemo_bis raised the priority of T146 and commented at the same time on April 22nd, 07:27:33Z. The notification's subject however is: "[Maniphest] [Raised Priority] T146: Make sure anti-vandalism features are up to snuff"; you have to look at the body itself to find that @Nemo_bis also commented.

aklapper wrote on 2014-06-03 15:15:19 (UTC)

That's not what I see; random example: @Nemo_bis raised the priority of T146 and commented at the same time on April 22nd, 07:27:33Z. The notification's subject however is: "[Maniphest] [Raised Priority] T146: Make sure anti-vandalism features are up to snuff"; you have to look at the body itself to find that @Nemo_bis also commented.

True. :( I've created the upstream ticket https://secure.phabricator.com/T5253 for that.