Page MenuHomePhabricator
Create Task
Maniphest T85007

VisualEditor JavaScript and tests should only be added if VisualEditor is installed
Closed, ResolvedPublic
Actions

Description

According to Antoine when he runs the tests using the following extensions together:

  • JsonConfig
  • Mantle
  • MobileApp
  • MobileFrontend
  • WikiGrok
  • ZeroBanner
  • ZeroPortal

This yields two failures:

ResourcesTest::testMissingDependencies
The module 'ext.visualEditor.mobileViewTarget' required by
'mobile.editor.ve' must exist
Failed asserting that an array contains 'ext.visualEditor.mobileViewTarget'.

ResourcesTest::testUnsatisfiableDependencies
Undefined index: ext.visualEditor.mobileViewTarget

Details

SubjectRepoBranchLines +/-
Don't add VisualEditor related modules if VE isn't installedmediawiki/extensions/MobileFrontendmaster+37 -27
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Dec 19 2014, 5:03 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson changed Security from none to None.
Jdlrobson subscribed.
hashar subscribed.Dec 19 2014, 9:37 PM
gerritbot added a project: Patch-For-Review.Dec 22 2014, 2:06 PM

Change 181403 had a related patch set uploaded (by Florianschmidtwelzow):
Don't add VisualEditor related modules if VE isn't installed

https://gerrit.wikimedia.org/r/181403

Patch-For-Review

Florian claimed this task.Dec 22 2014, 2:06 PM
Jdlrobson moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Dec 22 2014, 7:26 PM
Jdlrobson moved this task from 2015-16 Q4 to Needs Prioritization on the Web-Team-Backlog board.Dec 23 2014, 10:15 PM
gerritbot added a comment.Dec 24 2014, 6:56 PM

Change 181403 merged by jenkins-bot:
Don't add VisualEditor related modules if VE isn't installed

https://gerrit.wikimedia.org/r/181403

Florian mentioned this in rEMFRb20241d6d04a: Don't add VisualEditor related modules if VE isn't installed.Dec 24 2014, 6:56 PM
Florian closed this task as Resolved.Dec 24 2014, 7:01 PM
PleaseStand mentioned this in T88227: Multiple extensions: VisualEditor JavaScript should only be added if VisualEditor is installed.Jan 31 2015, 11:00 PM
Diffusion mentioned this in rMEXT451d465930f1: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:23 AM
• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q2 on the Web-Team-Backlog board.Mar 7 2018, 4:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL