Page MenuHomePhabricator
Create Task
Maniphest T85025

[Regression wmf13] Icons are misaligned in the Cite dropdown menu of the toolbar in mobile VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The icon for Cite>Website option is misaligned in the Cite menu of the toolbar in mobile VE

Screen_Shot_2014-12-19_at_1.42.58_PM.png (377×235 px, 20 KB)

Details

SubjectRepoBranchLines +/-
Redo VE toolbar stylingmediawiki/extensions/MobileFrontendmaster+28 -116
VisualEditorOverlay: Update for Idc299e23 in OOUImediawiki/extensions/MobileFrontendmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Dec 19 2014, 9:43 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added projects: VisualEditor, VisualEditor-MediaWiki-Mobile.
Ryasmeen changed Security from none to None.
Ryasmeen subscribed.
matmarex renamed this task from [Regression wmf13] The icon for Cite>Website option is misaligned in the Cite menu of the toolbar in mobile VE to [Regression wmf13] Icons for are misaligned in the Cite dropdown menu of the toolbar in mobile VE.Dec 19 2014, 11:43 PM
matmarex updated the task description. (Show Details)
matmarex subscribed.

All the icons look wonky. Probably caused by T78499, but I can't imagine what kind of thing MobileFrontend must have to be causing this.

matmarex claimed this task.Dec 19 2014, 11:48 PM
gerritbot added a project: Patch-For-Review.Dec 19 2014, 11:50 PM

Change 181215 had a related patch set uploaded (by Bartosz Dziewoński):
VisualEditorOverlay: Update for Idc299e23 in OOUI

https://gerrit.wikimedia.org/r/181215

Patch-For-Review

matmarex merged a task: T85072: Wonky toolbar menus in VE in mobile.Dec 20 2014, 11:48 PM
matmarex added a subscriber: Esanders.
Esanders renamed this task from [Regression wmf13] Icons for are misaligned in the Cite dropdown menu of the toolbar in mobile VE to [Regression wmf13] Icons are misaligned in the Cite dropdown menu of the toolbar in mobile VE.Dec 21 2014, 1:20 AM
gerritbot added a comment.Dec 22 2014, 1:30 PM

Change 181362 had a related patch set uploaded (by Esanders):
Redo VE toolbar styling

https://gerrit.wikimedia.org/r/181362

Patch-For-Review

gerritbot added a comment.Dec 22 2014, 9:40 PM

Change 181215 merged by jenkins-bot:
VisualEditorOverlay: Update for Idc299e23 in OOUI

https://gerrit.wikimedia.org/r/181215

matmarex mentioned this in rEMFRe0a82320fe14: VisualEditorOverlay: Update for Idc299e23 in OOUI.Dec 22 2014, 9:41 PM
Esanders added a comment.Dec 24 2014, 10:59 AM

Theme in desktop for question on gerrit:

pasted_file (287×744 px, 25 KB)

gerritbot added a comment.Dec 24 2014, 6:47 PM

Change 181362 merged by jenkins-bot:
Redo VE toolbar styling

https://gerrit.wikimedia.org/r/181362

Esanders mentioned this in rEMFR6bcf86afb597: Redo VE toolbar styling.Dec 24 2014, 6:47 PM
Liuxinyu970226 subscribed.Dec 25 2014, 4:42 AM
Jdforrester-WMF triaged this task as Medium priority.Jan 5 2015, 12:10 PM
Jdforrester-WMF moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.
Jdforrester-WMF closed this task as Resolved.Jan 5 2015, 2:19 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a project: WMF-deploy-2015-01-07_(1.25wmf14).
Liuxinyu970226 unsubscribed.Jan 5 2015, 2:39 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jan 7 2015, 9:25 PM
Ryasmeen added a comment.Jan 15 2015, 11:09 PM

Verified in en.wiki

Ryasmeen added a project: Verified-in-Phase2.Jan 15 2015, 11:10 PM
Diffusion mentioned this in rMEXT115e9e3fe9e0: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:23 AM
Diffusion mentioned this in rMEXT63715ecc0b5f: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:27 PM
Jdforrester-WMF edited a custom field.Mar 29 2015, 11:33 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 29 2015, 11:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL