Page MenuHomePhabricator

Enforce external MW_INSTALL_PATH
Closed, ResolvedPublic

Description

From https://gerrit.wikimedia.org/r/#/c/181063/

Change configuration of MobileFrontend build files to not default to a MW_INSTALL_PATH and rather just bail out loudly when the environment variable is not found.

This probably involves modifying Makefile and Gruntfile.

	Jdlrobson		Dec 19 5:58 PM

Let's be careful here. Ideally this should be the value used by Jenkins since that is the end goal (https://trello.com/c/o79gX3x5)

In my personal .profile I have `export MW_INSTALL_PATH=/Users/jrobson/git/vagrant/mediawiki` and ideally this value shouldn't be set.

Maybe we shouldn't have a default at all?

---

	Phuedx		Dec 19 6:02 PM

Patch Set 2:

I'd go one further: bail immediately – with a clear error message (!) – if it ain't set.

Event Timeline

Jhernandez raised the priority of this task from to Normal.
Jhernandez updated the task description. (Show Details)
Jhernandez moved this task to Upcoming on the Readers-Web-Backlog board.
Jhernandez changed Security from none to None.
Jhernandez added a subscriber: Jhernandez.

Do we want to do this? Does this cause any jenkins problems? (If the variable is defined then that is used, if not it is when it uses the default).

I guess the issue here is just making it clear to the end user what is happening.
Personally I'd rather have it bail out and tell me to set it so everything is clear but only if this doesn't cause issues for Jenkins

Change 181553 had a related patch set uploaded (by Jhernandez):
Require MW_INSTALL_PATH in both makefile and gruntfile

https://gerrit.wikimedia.org/r/181553

Patch-For-Review

I've submitted a patch ^ and it doesn't seem to cause any problem. Is there anything else to take into account?

Jdlrobson closed this task as Resolved.Dec 23 2014, 9:32 PM
Jdlrobson claimed this task.

Change 181553 merged by jenkins-bot:
Require MW_INSTALL_PATH in both makefile and gruntfile

https://gerrit.wikimedia.org/r/181553