Enforce external MW_INSTALL_PATH
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Jhernandez
	Dec 22 2014, 8:28 AM

Description

From https://gerrit.wikimedia.org/r/#/c/181063/

Change configuration of MobileFrontend build files to not default to a MW_INSTALL_PATH and rather just bail out loudly when the environment variable is not found.

This probably involves modifying Makefile and Gruntfile.

	Jdlrobson		Dec 19 5:58 PM

Let's be careful here. Ideally this should be the value used by Jenkins since that is the end goal (https://trello.com/c/o79gX3x5)

In my personal .profile I have `export MW_INSTALL_PATH=/Users/jrobson/git/vagrant/mediawiki` and ideally this value shouldn't be set.

Maybe we shouldn't have a default at all?

---

	Phuedx		Dec 19 6:02 PM

Patch Set 2:

I'd go one further: bail immediately – with a clear error message (!) – if it ain't set.

Details

	Subject	Repo	Branch	Lines +/-
	Require MW_INSTALL_PATH in both makefile and gruntfile	mediawiki/extensions/MobileFrontend	master	+25 -3

Customize query in gerrit

Related Objects

Mentioned In: rMEXTe73695ca29d3: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFR205a3d50c011: Require MW_INSTALL_PATH in both makefile and gruntfile

Event Timeline

Do we want to do this? Does this cause any jenkins problems? (If the variable is defined then that is used, if not it is when it uses the default).

I guess the issue here is just making it clear to the end user what is happening.
Personally I'd rather have it bail out and tell me to set it so everything is clear but only if this doesn't cause issues for Jenkins

Change 181553 had a related patch set uploaded (by Jhernandez):
Require MW_INSTALL_PATH in both makefile and gruntfile

https://gerrit.wikimedia.org/r/181553

Patch-For-Review

I've submitted a patch ^ and it doesn't seem to cause any problem. Is there anything else to take into account?

Jdlrobson closed this task as Resolved.Dec 23 2014, 9:32 PM

Jdlrobson claimed this task.

Change 181553 merged by jenkins-bot:
Require MW_INSTALL_PATH in both makefile and gruntfile

https://gerrit.wikimedia.org/r/181553

Diffusion mentioned this in rEMFR205a3d50c011: Require MW_INSTALL_PATH in both makefile and gruntfile.Dec 23 2014, 9:33 PM

Diffusion mentioned this in rMEXTe73695ca29d3: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:23 AM

• Phabricator_maintenance moved this task from Upcoming to 2014-15 Q2 on the Web-Team-Backlog board.Mar 7 2018, 4:34 AM