Page MenuHomePhabricator
Create Task
Maniphest T85129

[unplanned] In Special:ContentTranslation's Source and Target Language Selector Buttons, Drop-Downs Are Broken in RTL UI
Closed, ResolvedPublic
Actions

Description

In Special:ContentTranslation's source and target language selector buttons, the drop-downs are broken in RTL UI.

Details

SubjectRepoBranchLines +/-
Explicit text-align for language labels in the selectormediawiki/extensions/ContentTranslationmaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Dec 22 2014, 10:07 AM
Amire80 claimed this task.
Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added a project: ContentTranslation.
Amire80 changed Security from none to None.
Amire80 added subscribers: Aklapper, Amire80.
Amire80 added a subscriber: Pginer-WMF.
Amire80 added a comment.Dec 22 2014, 10:09 AM

@Pginer-WMF, isn't .background-image-svg supposed to handle RTL adaptation automatically?

Pginer-WMF added a comment.Dec 22 2014, 10:28 AM

I don't know. I think that mixin is based on a technique I proposed to support SVGs with PNG fallback, but I don't know if it does anything else regarding RTL. Feel free to check the code.

Amire80 added a comment.Dec 22 2014, 10:36 AM

I'm silly. The dropdown is OK. It's the text that is broken. Fixing...

gerritbot added a project: Patch-For-Review.Dec 22 2014, 10:39 AM

Change 181392 had a related patch set uploaded (by Amire80):
Explicit text-align for language labels in the selector

https://gerrit.wikimedia.org/r/181392

Patch-For-Review

Amire80 renamed this task from in Special:ContentTranslation source and target language selector buttons the dropdowns are broken in RTL UI to Unplanned: in Special:ContentTranslation source and target language selector buttons the dropdowns are broken in RTL UI.Dec 22 2014, 10:46 AM
Amire80 renamed this task from Unplanned: in Special:ContentTranslation source and target language selector buttons the dropdowns are broken in RTL UI to [unplanned] in Special:ContentTranslation source and target language selector buttons the dropdowns are broken in RTL UI.
Amire80 added a project: LE-Sprint-80.
Amire80 moved this task from Backlog to In Review on the LE-Sprint-80 board.
gerritbot added a comment.Dec 22 2014, 12:04 PM

Change 181392 merged by jenkins-bot:
Explicit text-align for language labels in the selector

https://gerrit.wikimedia.org/r/181392

• santhosh mentioned this in rECTX1f8dc24732ea: Explicit text-align for language labels in the selector.Dec 22 2014, 12:04 PM
Amire80 closed this task as Resolved.Dec 22 2014, 12:05 PM
Amire80 moved this task from In Review to Done on the LE-Sprint-80 board.
RandomDSdevel renamed this task from [unplanned] in Special:ContentTranslation source and target language selector buttons the dropdowns are broken in RTL UI to [unplanned] In Special:ContentTranslation's Source and Target Language Selector Buttons, Drop-downs are Broken in RTL UI.Mar 2 2015, 9:45 PM
RandomDSdevel renamed this task from [unplanned] In Special:ContentTranslation's Source and Target Language Selector Buttons, Drop-downs are Broken in RTL UI to [unplanned] In Special:ContentTranslation's Source and Target Language Selector Buttons, Drop-Downs Are Broken in RTL UI.
RandomDSdevel updated the task description. (Show Details)
RandomDSdevel awarded a token.
Amire80 mentioned this in rMEXTe42b8d9edeb4: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Mar 11 2015, 6:23 AM
Aklapper added a project: RTL.Jun 2 2015, 2:20 PM
Restricted Application added a project: I18n. · View Herald TranscriptJun 2 2015, 2:20 PM
• Phabricator_maintenance removed a parent task: T2745: [DO NOT USE] RTL/bidirectional issues (tracking) [superseded by #RTL].Feb 22 2019, 1:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL