Page MenuHomePhabricator
Create Task
Maniphest T85194

Navigating to Your Dashboard Makes the Published Translation Into a Draft
Closed, ResolvedPublic
Actions

Description

After publishing a translation, navigating to your dashboard using the 'All translations' link makes it into a draft. Similarly, just closing the window also changes the page's status to that of a draft. This happens because a save hook fires just before your browser window's content unloads. This should be done conditionally by checking whether there is anything to save or not.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
While navigating away, save the translation only if something changedmediawiki/extensions/ContentTranslationmaster+9 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

santhosh created this task.Dec 23 2014, 5:16 AM
santhosh claimed this task.
santhosh raised the priority of this task from to High.
santhosh updated the task description. (Show Details)
santhosh added projects: ContentTranslation-Release3, ContentTranslation, LE-Sprint-81.
santhosh subscribed.
gerritbot added a project: Patch-For-Review.Dec 23 2014, 5:18 AM

Change 181543 had a related patch set uploaded (by Santhosh):
While navigating away, save the translation only if something changed

https://gerrit.wikimedia.org/r/181543

Patch-For-Review

• Arrbee moved this task from Backlog to Sprint 81 on the ContentTranslation-Release3 board.Dec 23 2014, 6:20 AM
santhosh moved this task from Backlog to In Progress on the LE-Sprint-81 board.Dec 23 2014, 7:08 AM
santhosh moved this task from In Progress to In Review on the LE-Sprint-81 board.Dec 23 2014, 11:07 AM
santhosh merged a task: T85264: Translation dashboard does not display pages recently published.Dec 29 2014, 7:15 AM
santhosh added a subscriber: • Arrbee.
Nikerabbit renamed this task from Navigating to dashboard make the published transltion draft to Navigating to dashboard makes the published translation a draft.Jan 6 2015, 7:03 AM
Nikerabbit set Security to None.
gerritbot added a comment.Jan 6 2015, 1:20 PM

Change 181543 merged by jenkins-bot:
While navigating away, save the translation only if something changed

https://gerrit.wikimedia.org/r/181543

Amire80 mentioned this in rECTX245ddb38fff2: While navigating away, save the translation only if something changed.Jan 6 2015, 1:20 PM
• Arrbee closed this task as Resolved.Jan 7 2015, 7:16 AM

Verified.

• Arrbee mentioned this in T85988: Published articles are displayed as drafts if Special:CX is refreshed.Jan 7 2015, 8:57 AM
• Arrbee moved this task from In Review to Done on the LE-Sprint-81 board.Jan 7 2015, 1:47 PM
RandomDSdevel renamed this task from Navigating to dashboard makes the published translation a draft to Navigating to Your Dashboard Makes the Published Translation Into a Draft.Mar 2 2015, 9:08 PM
RandomDSdevel updated the task description. (Show Details)
RandomDSdevel awarded a token.
santhosh mentioned this in rMEXTa4cdda2a8831: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Mar 11 2015, 6:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits