Page MenuHomePhabricator
Create Task
Maniphest T85241

Login form checkbox labels wind up with too much line spacing when spanning multiple lines
Closed, ResolvedPublic
Actions

Description

Go to the account creation form when already logged in - the label for the checkbox 'Use a temporary random password and send it to the specified email address' has too much line spacing when spanning multiple lines.

pasted_file (412×361 px, 18 KB)

Given the size of the checkbox, the correct behaviour would probably be something like

pasted_file (393×323 px, 25 KB)

This appears to be due to mw-ui's stying, and occurs regardless of browser.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki.ui: checkbox: Correct alignment of long labelsmediawiki/coremaster+10 -1
Customize query in gerrit

Related Objects

Event Timeline

Isarra created this task.Dec 23 2014, 7:50 PM
Isarra raised the priority of this task from to Needs Triage.
Isarra updated the task description. (Show Details)
Isarra added a project: MediaWiki-User-login-and-signup.
Isarra subscribed.
matmarex updated the task description. (Show Details)Dec 23 2014, 7:53 PM
matmarex set Security to None.
Isarra updated the task description. (Show Details)Dec 23 2014, 8:06 PM
wctaiwan updated the task description. (Show Details)Dec 23 2014, 8:19 PM
wctaiwan updated the task description. (Show Details)Dec 23 2014, 8:22 PM
gerritbot added a project: Patch-For-Review.Dec 23 2014, 8:51 PM

Change 181674 had a related patch set uploaded (by Bartosz Dziewoński):
[WIP] mediawiki.ui: checkbox: Correct alignment of long labels

https://gerrit.wikimedia.org/r/181674

Patch-For-Review

matmarex added a project: Design.Dec 28 2014, 5:06 PM
matmarex added a subscriber: • violetto.
matmarex subscribed.
gerritbot subscribed.Jan 21 2015, 5:35 PM

Change 181674 merged by Prtksxna:
mediawiki.ui: checkbox: Correct alignment of long labels

https://gerrit.wikimedia.org/r/181674

matmarex mentioned this in rMW5a9350483313: mediawiki.ui: checkbox: Correct alignment of long labels.Jan 21 2015, 5:36 PM
matmarex closed this task as Resolved.Jan 21 2015, 5:56 PM
matmarex claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits