Page MenuHomePhabricator
Create Task
Maniphest T85292

Notification overlay back button behaviour broken
Closed, ResolvedPublic
Actions

Description

Click notification badge
Click hard browser back button
See this:

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendwmf/1.25wmf13+26 -3Fix notification overlay back behaviour
mediawiki/extensions/MobileFrontendmaster+21 -4Fix notification overlay back behaviour
mediawiki/extensions/MobileFrontendmaster+13 -5Fix: Close notifications Overlay correctly when click on cancel button
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Dec 24 2014, 9:41 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.
Jdlrobson added a comment.Dec 24 2014, 9:43 PM

(above happens on mobile device)
On tablet I get this:

Aklapper added a comment.Dec 28 2014, 3:31 PM

@Jdlrobson: Which project(s) is this about? Mobile? Echo? Associating at least one project is welcome.

Jdlrobson added a comment.Dec 29 2014, 6:34 PM

Actually this one is even worse than expected. In Firefox on beta labs even clicking close seems to break the rendering.

Jdlrobson closed this task as Invalid.Dec 29 2014, 6:46 PM
Jdlrobson claimed this task.
This comment was removed by Jdlrobson.
Jdlrobson reopened this task as Open.Dec 29 2014, 6:46 PM
gerritbot added a project: Patch-For-Review.Dec 30 2014, 12:16 AM

Change 182118 had a related patch set uploaded (by Florianschmidtwelzow):
Fix: Close notifications Overlay correctly when click on cancel button

https://gerrit.wikimedia.org/r/182118

Patch-For-Review

gerritbot added a comment.Dec 30 2014, 1:05 AM

Change 182128 had a related patch set uploaded (by Jdlrobson):
Fix notification overlay back behaviour

https://gerrit.wikimedia.org/r/182128

Patch-For-Review

gerritbot added a comment.Dec 30 2014, 1:10 AM

Change 182118 abandoned by Florianschmidtwelzow:
Fix: Close notifications Overlay correctly when click on cancel button

Reason:
https://gerrit.wikimedia.org/r/182128

https://gerrit.wikimedia.org/r/182118

gerritbot added a comment.Dec 31 2014, 12:21 AM

Change 182128 merged by jenkins-bot:
Fix notification overlay back behaviour

https://gerrit.wikimedia.org/r/182128

Florian closed this task as Resolved.Dec 31 2014, 12:35 AM
gerritbot added a comment.Jan 5 2015, 10:48 PM

Change 182944 had a related patch set uploaded (by Kaldari):
Fix notification overlay back behaviour

https://gerrit.wikimedia.org/r/182944

Patch-For-Review

gerritbot added a comment.Jan 6 2015, 12:58 AM

Change 182944 merged by Aude:
Fix notification overlay back behaviour

https://gerrit.wikimedia.org/r/182944

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL