Maniphest T85292

Notification overlay back button behaviour broken
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 24 2014, 9:41 PM

Tags

Subscribers

Description

Click notification badge
Click hard browser back button
See this:

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	wmf/1.25wmf13	+26 -3	Fix notification overlay back behaviour
	mediawiki/extensions/MobileFrontend	master	+21 -4	Fix notification overlay back behaviour
	mediawiki/extensions/MobileFrontend	master	+13 -5	Fix: Close notifications Overlay correctly when click on cancel button

Customize query in gerrit

Related Objects

Mentioned In: rMEXT388d9b0ba7a7: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFRd237ebc1ca9b: Fix notification overlay back behaviour
rEMFRe988258633ed: Fix notification overlay back behaviour

Event Timeline

Jdlrobson created this task.Dec 24 2014, 9:41 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a subscriber: Jdlrobson.

(above happens on mobile device)
On tablet I get this:

@Jdlrobson: Which project(s) is this about? Mobile? Echo? Associating at least one project is welcome.

Woops

Jdlrobson moved this task from Incoming to Old Unorganized Resolved Tasks on the Readers-Web-Backlog board.Dec 29 2014, 6:30 PM

Actually this one is even worse than expected. In Firefox on beta labs even clicking close seems to break the rendering.

Jdlrobson closed this task as Invalid.Dec 29 2014, 6:46 PM

Jdlrobson claimed this task.

This comment was removed by Jdlrobson.

Jdlrobson reopened this task as Open.Dec 29 2014, 6:46 PM

Jdlrobson merged a task: T85488: NotificationOverlay back/close function broken.Dec 29 2014, 11:31 PM

Jdlrobson added a subscriber: Florian.

Change 182118 had a related patch set uploaded (by Florianschmidtwelzow):
Fix: Close notifications Overlay correctly when click on cancel button

https://gerrit.wikimedia.org/r/182118

Patch-For-Review

Change 182128 had a related patch set uploaded (by Jdlrobson):
Fix notification overlay back behaviour

https://gerrit.wikimedia.org/r/182128

Patch-For-Review

Jdlrobson moved this task from Old Unorganized Resolved Tasks to Needs Prioritization on the Readers-Web-Backlog board.Dec 30 2014, 1:06 AM

Change 182118 abandoned by Florianschmidtwelzow:
Fix: Close notifications Overlay correctly when click on cancel button

Reason:
https://gerrit.wikimedia.org/r/182128

https://gerrit.wikimedia.org/r/182118

Change 182128 merged by jenkins-bot:
Fix notification overlay back behaviour

https://gerrit.wikimedia.org/r/182128

Diffusion mentioned this in rEMFRe988258633ed: Fix notification overlay back behaviour.Dec 31 2014, 12:21 AM

Florian closed this task as Resolved.Dec 31 2014, 12:35 AM

Change 182944 had a related patch set uploaded (by Kaldari):
Fix notification overlay back behaviour

https://gerrit.wikimedia.org/r/182944

Patch-For-Review

Change 182944 merged by Aude:
Fix notification overlay back behaviour

https://gerrit.wikimedia.org/r/182944

kaldari mentioned this in rEMFRd237ebc1ca9b: Fix notification overlay back behaviour.Jan 6 2015, 12:58 AM

Diffusion mentioned this in rMEXT388d9b0ba7a7: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:23 AM

• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q2 on the Readers-Web-Backlog board.Mar 7 2018, 4:34 AM