Don't use jQuery's live method in MoodBar
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Mattflaschen-WMF
	Dec 25 2014, 4:32 AM

Description

ext.moodBar.dashboard.js uses .live(), which has been entirely removed, in several places.

Details

Subject	Repo	Branch	Lines +/-
Stop using jQuery.live	mediawiki/extensions/MoodBar	wmf/1.25wmf13	+11 -9
Stop using jQuery.live	mediawiki/extensions/MoodBar	wmf/1.25wmf12	+11 -9
Stop using jQuery.live	mediawiki/extensions/MoodBar	master	+11 -9

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Krinkle	T46740 Upgrade jQuery from 1.8.x to 1.11.x
Resolved	None	T67399 Don't use deprecated features removed in jQuery 1.9
Resolved	• Mattflaschen-WMF	T85506 Update extensions maintained by Collaboration team for jQuery 1.9 changes
Resolved	Krenair	T85300 Don't use jQuery's live method in MoodBar

Event Timeline

• Mattflaschen-WMF created this task.Dec 25 2014, 4:32 AM

• Mattflaschen-WMF raised the priority of this task from to High.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added projects: MediaWiki-extensions-MoodBar, Collaboration-Team-Triage.

• Mattflaschen-WMF added subscribers: Unknown Object (MLST), greg, Jdforrester-WMF and 5 others.

Liuxinyu970226 subscribed.Dec 27 2014, 5:03 AM

It's not possible to respond to, hide or delete feedback anymore. Is that related to this bug?

Krenair subscribed.Jan 3 2015, 6:39 PM

It's not possible to respond to, hide or delete feedback anymore. Is that related to this bug?

I don't know, but if nobody fixes that in few days then the extension should be disabled (as being abandoned).

Looks like it.

Krenair raised the priority of this task from High to Unbreak Now!.Jan 4 2015, 6:27 PM

Krenair set Security to None.

Change 182694 had a related patch set uploaded (by Alex Monk):
Stop using jQuery.live

https://gerrit.wikimedia.org/r/182694

Patch-For-Review

Krenair claimed this task.Jan 4 2015, 7:05 PM

• Mattflaschen-WMF moved this task from Untriaged to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.Jan 5 2015, 6:53 PM

• Mattflaschen-WMF moved this task from Sprint O (ends Jan 27) to Code Review on the Collaboration-Team-Triage board.

Change 182694 merged by jenkins-bot:
Stop using jQuery.live

https://gerrit.wikimedia.org/r/182694

In T85300#953375, @Sjoerddebruin wrote:

It's not possible to respond to, hide or delete feedback anymore. Is that related to this bug?

Yes, in addition to T85512: Stop using 'hover' event string in Collaboration team extensions, which I'm going to do now.

• Mattflaschen-WMF mentioned this in rEMOOf53268f94f2f: Stop using jQuery.live.Jan 5 2015, 7:37 PM

Change 182871 had a related patch set uploaded (by Mattflaschen):
Stop using jQuery.live

https://gerrit.wikimedia.org/r/182871

Patch-For-Review

Change 182872 had a related patch set uploaded (by Mattflaschen):
Stop using jQuery.live

https://gerrit.wikimedia.org/r/182872

Patch-For-Review

Change 182871 merged by jenkins-bot:
Stop using jQuery.live

https://gerrit.wikimedia.org/r/182871

Change 182872 merged by jenkins-bot:
Stop using jQuery.live

https://gerrit.wikimedia.org/r/182872

• Mattflaschen-WMF mentioned this in rEMOO69f57aaf0ad2: Stop using jQuery.live.Jan 5 2015, 8:20 PM

• Mattflaschen-WMF mentioned this in rEMOOa646aea2eaf9: Stop using jQuery.live.

This fix and the MoodBar part of T85512: Stop using 'hover' event string in Collaboration team extensions is now deployed to all Wikimedia wikis (of course, MoodBar is only enabled on a handful, as before).

Liuxinyu970226 unsubscribed.Jan 6 2015, 2:53 AM

Jdforrester-WMF removed a project: Patch-For-Review.Mar 3 2015, 5:27 PM

RandomDSdevel awarded a token.Mar 4 2015, 7:05 PM

Krenair mentioned this in rMEXT6496d63ef35d: Updated mediawiki/extensions Project: mediawiki/extensions/MoodBar….Mar 11 2015, 6:23 AM

Luke081515 removed a subscriber: • wikibugs-l-list.Jan 28 2016, 5:56 PM