Maniphest T85326

shinken.wmflabs.org redirects on https-login to http
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Se4598
	Dec 25 2014, 7:10 PM

Tags

Referenced Files

None

Subscribers

Description

the POST-answer after logging in with HTTPS via https://shinken.wmflabs.org/user/login redirects one to HTTP.

Event Timeline

Se4598 created this task.Dec 25 2014, 7:10 PM

Se4598 raised the priority of this task from to Needs Triage.

Se4598 updated the task description. (Show Details)

Se4598 added projects: Shinken, Wikimedia-Labs-General.

Se4598 added subscribers: Se4598, yuvipanda.

yuvipanda added projects: Cloud-Services, observability.Dec 25 2014, 7:11 PM

yuvipanda set Security to None.

Liuxinyu970226 subscribed.Dec 26 2014, 7:52 AM

When you POST that login form, it returns HTTP 303 See Other with the http: location.

I did a bit of digging through the shinken source code and found https://github.com/naparuba/shinken/blob/master/shinken/webui/bottlewebui.py#L997
Whereas it's supposed to check HTTP_X_FORWARDED_PROTO like http://bottlepy.org/docs/dev/_modules/bottle.html#BaseRequest.url

https://github.com/naparuba/shinken/pull/1724

Krenair edited projects, added Patch-For-Review; removed Wikimedia-Labs-General.Oct 16 2015, 7:41 PM

Krenair added a project: Upstream.Oct 27 2015, 2:23 AM

I don't really know what's going on upstream but it sounds like a load of things have been changed, the patch might not still be valid.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 17 2015, 4:37 PM

• chasemp triaged this task as High priority.Nov 30 2015, 5:10 PM

• chasemp subscribed.

Krenair removed Krenair as the assignee of this task.Jan 12 2016, 11:16 PM

Upstream ticket is closed and says "can you try webui2 instead ? and make a PR for the new webui2 if you encounter this issue with this version ?"

Luke081515 moved this task from Triage to Backlog on the Cloud-Services board.Mar 25 2016, 4:11 PM

• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:56 PM

faidon removed projects: Patch-For-Review, observability.Jul 20 2017, 1:21 PM

Chicocvenancio subscribed.Jan 25 2018, 1:29 PM

The shinken project has been closed and deleted.