Page MenuHomePhabricator
Create Task
Maniphest T85340

The messages Wikibase-validator-sitelink-conflict and Wikibase-undo-title show HTML when used as an error after trying to reset an item page
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

A user wrongly removed many sitelinks from an item page. I went to the item page's history and clicked on a good previous version. When I tried to reset the item page to that version, I got a page that showed Wikibase-validator-sitelink-conflict as an error message. All the links appeared as HTML - for example "<a class="external text" href="//en.wikipedia.org/wiki/Missa_solemnis_(Beethoven)">enwiki:Missa solemnis (Beethoven)</a>" instead of "enwiki:Missa solemnis (Beethoven)" as a clickable hyperlink.

The title of the page was the message Wikibase-undo-title, and it showed "$1" instead of the item's label.

My UI language is Hebrew.

The item I was trying to restore is https://www.wikidata.org/wiki/Q723790 .

The version I was trying to restore is https://www.wikidata.org/w/index.php?title=Q723790&oldid=123262931 .

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+1 -1Do not show raw HTML in EditEntityAction::showUndoErrorPage
mediawiki/extensions/Wikibasewmf/1.25wmf19+1 -1Don't implicitly parse messages passed to OutputPage::addWikiText
mediawiki/extensions/Wikibasemaster+8 -8Fix broken undo error message
mediawiki/extensions/Wikibasemaster+1 -1Don't implicitly parse messages passed to OutputPage::addWikiText
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Dec 26 2014, 11:50 AM
Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added projects: MediaWiki-extensions-WikibaseRepository, I18n.
Amire80 added a subscriber: Amire80.
Lydia_Pintscher triaged this task as Medium priority.Dec 27 2014, 11:56 AM
Lydia_Pintscher added a project: Wikidata.
Lydia_Pintscher set Security to None.
Lydia_Pintscher added a subscriber: hoo.
matej_suchanek merged a task: T84890: When restoring is not possible, the interface is broken.Dec 27 2014, 4:39 PM
matej_suchanek added subscribers: matej_suchanek, aude, thiemowmde.
• JohnLewis moved this task from incoming to needs discussion or investigation on the Wikidata board.Jan 24 2015, 1:21 PM
Sjoerddebruin added a subscriber: Sjoerddebruin.Feb 23 2015, 4:44 PM

Can confirm this, can somebody fix this? This is a crucial part of the interface, especially for new users.

gerritbot added a subscriber: gerritbot.Feb 23 2015, 5:28 PM

Change 192344 had a related patch set uploaded (by Hoo man):
Don't implicitly parse messages passed to OutputPage::addWikiText

https://gerrit.wikimedia.org/r/192344

Patch-For-Review

gerritbot added a comment.Feb 23 2015, 5:39 PM

Change 192344 merged by jenkins-bot:
Don't implicitly parse messages passed to OutputPage::addWikiText

https://gerrit.wikimedia.org/r/192344

hoo mentioned this in rEWBAcd16e21279f4: Don't implicitly parse messages passed to OutputPage::addWikiText.Feb 23 2015, 5:39 PM
hoo closed this task as Resolved.Feb 23 2015, 5:40 PM
hoo claimed this task.
In T85340#1059180, @Sjoerddebruin wrote:

Can confirm this, can somebody fix this? This is a crucial part of the interface, especially for new users.

Done ;)

gerritbot added a comment.Feb 23 2015, 6:28 PM

Change 192364 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix broken undo error message

https://gerrit.wikimedia.org/r/192364

Patch-For-Review

thiemowmde reopened this task as Open.Feb 23 2015, 6:29 PM

The headline is still displaying an $1. Fixed in my patch.

gerritbot added a comment.Feb 24 2015, 7:07 PM

Change 192598 had a related patch set uploaded (by Hoo man):
Don't implicitly parse messages passed to OutputPage::addWikiText

https://gerrit.wikimedia.org/r/192598

Patch-For-Review

Aklapper added a project: Patch-For-Review.Feb 25 2015, 9:20 AM
gerritbot added a comment.Feb 25 2015, 1:58 PM

Change 192364 merged by jenkins-bot:
Fix broken undo error message

https://gerrit.wikimedia.org/r/192364

thiemowmde mentioned this in rEWBAff4057e12983: Fix broken undo error message.Feb 25 2015, 1:59 PM
gerritbot added a comment.Feb 25 2015, 2:13 PM

Change 192598 merged by jenkins-bot:
Don't implicitly parse messages passed to OutputPage::addWikiText

https://gerrit.wikimedia.org/r/192598

hoo mentioned this in rEWBA52b4d30a01f3: Don't implicitly parse messages passed to OutputPage::addWikiText.Feb 25 2015, 2:13 PM
Lydia_Pintscher closed this task as Resolved.Feb 25 2015, 3:10 PM
Lydia_Pintscher added a subscriber: Lydia_Pintscher.
Diffusion mentioned this in rMEXT53f0893245d0: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 11 2015, 6:27 AM
Diffusion mentioned this in rMEXT7df7897d269e: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….
matej_suchanek reopened this task as Open.May 17 2015, 8:23 AM

The heading has indeed been fixed, however I can still see HTML in the error message.

Taken from https://www.wikidata.org/w/index.php?title=Q408110&action=edit&restore=214635733

bug.jpg (473×1 px, 126 KB)

matej_suchanek removed a project: Patch-For-Review.May 17 2015, 8:23 AM
thiemowmde removed hoo as the assignee of this task.May 18 2015, 10:06 AM
thiemowmde added a project: patch-welcome.
matej_suchanek merged a task: T59533: Double escaping in restore failure message.Jun 13 2015, 8:38 AM
matej_suchanek added subscribers: Fomafix, liangent, Wikidata-bugs, Lucie.
Fomafix added a comment.Jul 15 2015, 6:18 AM

The HTML code is still in the message:

T85340.png (322×661 px, 30 KB)

Can this problem solved by replacing in EditEntityAction.php:

$this->getOutput()->addWikiText( $status->getMessage()->text() );

by

$this->getOutput()->addHTML( $status->getMessage()->escaped() );
gerritbot added a comment.Jul 15 2015, 11:19 PM

Change 224972 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Do not show raw HTML in EditEntityAction::showUndoErrorPage

https://gerrit.wikimedia.org/r/224972

gerritbot added a project: Patch-For-Review.Jul 15 2015, 11:19 PM
thiemowmde added a project: Wikidata-Sprint-2015-06-30.Jul 15 2015, 11:20 PM
thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2015-06-30 board.
• Addshore closed this task as Resolved.Jul 16 2015, 8:42 AM
• Addshore claimed this task.
gerritbot added a comment.Jul 16 2015, 8:46 AM

Change 224972 merged by jenkins-bot:
Do not show raw HTML in EditEntityAction::showUndoErrorPage

https://gerrit.wikimedia.org/r/224972

thiemowmde mentioned this in rEWBA4956e37f27fd: Do not show raw HTML in EditEntityAction::showUndoErrorPage.Jul 16 2015, 8:46 AM
Diffusion mentioned this in rMEXT7798a445adab: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 16 2015, 8:46 AM
matej_suchanek added a comment.Jul 16 2015, 8:57 AM

Thanks!

matej_suchanek removed a project: Patch-For-Review.Jul 16 2015, 8:58 AM
matej_suchanek removed a subscriber: gerritbot.
thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2015-06-30 board.Jul 16 2015, 12:06 PM
Tobi_WMDE_SW edited a custom field.Aug 5 2015, 9:05 AM
matej_suchanek removed a project: patch-welcome.Nov 21 2015, 9:04 AM
matej_suchanek removed subscribers: Wikidata-bugs, matej_suchanek.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL