Page MenuHomePhabricator
Create Task
Maniphest T85480

in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

As a logged in user with beta access to VisualEditor using MobileFrontend, edit a new page on beta labs, e.g. http://en.m.wikipedia.beta.wmflabs.org/wiki/Apsidufapodifuasdf or some such.

Click the pencil icon to edit the page. I think this should bring up VE, but brings up wikitext editor instead.

From the gear menu, click Edit to invoke VE

Again from the gear menu, click Edit source.

VE fails to disappear. Wikitext editor does not appear. No VE controls like Bold/Italic/Link etc. function at this point.

This is the failure at https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/455/testReport/(root)/VisualEditor%20Mobile/Switch_from_VisualEditor_to_source_editor/

Details

SubjectRepoBranchLines +/-
Fix naming issue to restore ability to switch between editorsmediawiki/extensions/MobileFrontendwmf/1.25wmf13+6 -6
Fix naming issue to restore ability to switch between editorsmediawiki/extensions/MobileFrontendmaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

• Cmcmahon created this task.Dec 29 2014, 9:57 PM
• Cmcmahon raised the priority of this task from to High.
• Cmcmahon updated the task description. (Show Details)
• Cmcmahon added projects: MobileFrontend-beta, VisualEditor, Contributors-Team.
• Cmcmahon subscribed.
• Cmcmahon updated the task description. (Show Details)Dec 29 2014, 10:10 PM
• Cmcmahon added a project: Browser-test-bug.
• Cmcmahon set Security to None.
Etonkovidova subscribed.Dec 29 2014, 10:24 PM

The following error is displayed:
Uncaught TypeError: boolean is not a functionload.php?debug=false&lang=en&modules=mobile.abusefilter|mobile.editor.common%2Coverlay&skin=minerva…:8 Overlay.extend.hideload.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cmwcore|mobile.editor.ve|oojs-ui&skin=m…:624 EditorOverlayBase.extend.hideVM367:16 Class.extend._hideOverlayVM367:17 Class.extend.replaceCurrentload.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cmwcore|mobile.editor.ve|oojs-ui&skin=m…:625 (anonymous function)load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141220T…:45 fireload.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141220T…:46 self.fireWithload.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141220T…:47 deferred.(anonymous function)load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141220T…:168 mw.loader.usingload.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cmwcore|mobile.editor.ve|oojs-ui&skin=m…:625 EditorOverlayBase.extend.switchToSourceEditorload.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cmwcore|mobile.editor.ve|oojs-ui&skin=m…:624 (anonymous function)load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141220T…:65 jQuery.event.dispatchload.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141220T…:60 elemData.handle

Jdlrobson claimed this task.Dec 29 2014, 11:28 PM
gerritbot added a project: Patch-For-Review.Dec 29 2014, 11:30 PM

Change 182113 had a related patch set uploaded (by Jdlrobson):
Fix naming issue to restore ability to switch between editors

https://gerrit.wikimedia.org/r/182113

Patch-For-Review

Jdlrobson edited projects, added Web-Team-Backlog; removed MobileFrontend-beta.Dec 29 2014, 11:30 PM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
gerritbot added a comment.Dec 30 2014, 10:34 PM

Change 182113 merged by jenkins-bot:
Fix naming issue to restore ability to switch between editors

https://gerrit.wikimedia.org/r/182113

Diffusion mentioned this in rEMFR551b5d112481: Fix naming issue to restore ability to switch between editors.Dec 30 2014, 10:34 PM
Jdlrobson closed this task as Resolved.Dec 30 2014, 11:00 PM
Etonkovidova added a comment.Dec 31 2014, 12:18 AM

Verified in betalabs. test2 still have problems with switching between Edit and Edit source.

matmarex reopened this task as Open.Jan 5 2015, 4:29 PM
matmarex subscribed.

This probably needs some swift backporting to wmf13?

gerritbot added a comment.Jan 5 2015, 10:45 PM

Change 182943 had a related patch set uploaded (by Kaldari):
Fix naming issue to restore ability to switch between editors

https://gerrit.wikimedia.org/r/182943

Patch-For-Review

gerritbot added a comment.Jan 6 2015, 12:58 AM

Change 182943 merged by Aude:
Fix naming issue to restore ability to switch between editors

https://gerrit.wikimedia.org/r/182943

kaldari mentioned this in rEMFRdb87d8cc670b: Fix naming issue to restore ability to switch between editors.Jan 6 2015, 12:58 AM
matmarex closed this task as Resolved.Jan 6 2015, 2:06 AM
matmarex mentioned this in T84897: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web.

Thanks. VE on mobile is apparently still broken, tracked as T85897.

Jdforrester-WMF added projects: WMF-deploy-2015-01-07_(1.25wmf14), WMF-deploy-2014-12-17_(1.25wmf13).Jan 7 2015, 4:20 PM
Jdforrester-WMF moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 7 2015, 9:19 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jan 7 2015, 9:25 PM
Etonkovidova added a project: Verified-in-Phase0.Jan 9 2015, 12:44 AM
Ryasmeen subscribed.Jan 15 2015, 10:53 PM

Verified in en.wiki

Ryasmeen added a project: Verified-in-Phase2.Jan 15 2015, 10:53 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM
Jdforrester-WMF edited a custom field.Feb 2 2015, 8:00 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:02 PM
Diffusion mentioned this in rMEXTc531a4977319: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:23 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:32 PM
• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:26 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 7 2018, 4:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL