Page MenuHomePhabricator

Back arrow appears before other VE controls in MobileFrontend but does nothing
Closed, ResolvedPublic

Description

As a logged in user with access to VE in MobileFrontend, bring up a random page and click the pencil icon to edit with VE e.g. http://en.m.wikipedia.beta.wmflabs.org/wiki/0.6922277312143298#/random.

Note that in the upper left, the back-arrow icon "escape" button appears before the other controls.

Click the back-arrow escape icon as the page loads, before the page is finished loading. Nothing happens.

This is the failure at https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/455/testReport/(root)/VisualEditor%20Mobile/Going_back_from_save_screen_in_VisualEditor/

Event Timeline

Cmcmahon raised the priority of this task from to Needs Triage.
Cmcmahon updated the task description. (Show Details)
Cmcmahon subscribed.
Jdforrester-WMF renamed this task from Back arrow appears before other VE controls but does nothing to Back arrow appears before other VE controls in MobileFrontend but does nothing.Jan 5 2015, 12:29 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF set Security to None.

Uncaught TypeError: boolean is not a function in Overlay.extend.hide

It's trying to call this._hasChanged() , while this._hasChanged is a boolean property (set to true). Appears to be related to https://gerrit.wikimedia.org/r/#/c/182113/ , which was cherry-picked to wmf13 but doesn't seem to have solved everything.

I stand corrected, this is now fixed in master. The error above is in wmf13, so we seem to have missed another patch that should be cherry-picked.

Verified the fix in Betalabs and test2