Maniphest T85494

(1) Add new jscs rule disallowImplicitTypeConversion and fix coding errors
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 30 2014, 12:14 AM

Tags

Referenced Files

None

Subscribers

Description

Add this rule to the .jscsrc config:

https://github.com/jscs-dev/node-jscs#disallowimplicittypeconversion

Fix the existing errors

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors	mediawiki/extensions/MobileFrontend	master	+6 -6

Customize query in gerrit

Related Objects

Mentioned In: rMEXT0d6cba6aed5e: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFR60de4b2d4880: Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors

Event Timeline

Jdlrobson created this task.Dec 30 2014, 12:14 AM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson triaged this task as Lowest priority.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog-Archived.

Jdlrobson moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog-Archived board.

Jdlrobson moved this task from Old Unorganized Resolved Tasks to 2015-16 Q4 on the Web-Team-Backlog-Archived board.

Jdlrobson subscribed.

• bmansurov claimed this task.Dec 30 2014, 12:37 AM

• bmansurov set Security to None.

Change 182127 had a related patch set uploaded (by Bmansurov):
Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors

https://gerrit.wikimedia.org/r/182127

Patch-For-Review

• bmansurov moved this task from 2015-16 Q4 to Needs Prioritization on the Web-Team-Backlog-Archived board.Dec 30 2014, 12:52 AM

Change 182127 merged by jenkins-bot:
Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors

https://gerrit.wikimedia.org/r/182127

• bmansurov mentioned this in rEMFR60de4b2d4880: Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors.Dec 30 2014, 10:22 PM

Jdlrobson closed this task as Resolved.Dec 30 2014, 10:26 PM

Diffusion mentioned this in rMEXT0d6cba6aed5e: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:23 AM

• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q2 on the Web-Team-Backlog-Archived board.Mar 7 2018, 4:35 AM