Page MenuHomePhabricator
Create Task
Maniphest T85512

Stop using 'hover' event string in Collaboration team extensions
Closed, ResolvedPublic
Actions

Description

The event type 'hover' (https://jquery.com/upgrade-guide/1.9/#quot-hover-quot-pseudo-event) is no longer supported in string form in jQuery 1.9+.

This appears once in ext.moodBar.dashboard.js (delegate should also be dropped while this part of the code is being touched) and another time in flow-component.js.

The replacement is 'mouseenter mouseleave'.

Details

SubjectRepoBranchLines +/-
Fix to use 'mouseenter mouseleave' instead of 'hover'mediawiki/extensions/Flowmaster+1 -1
Fix dashboard links that are visible on hovermediawiki/extensions/MoodBarwmf/1.25wmf13+1 -4
Fix dashboard links that are visible on hovermediawiki/extensions/MoodBarwmf/1.25wmf12+1 -4
Fix dashboard links that are visible on hovermediawiki/extensions/MoodBarmaster+1 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Mattflaschen-WMF created this task.Dec 30 2014, 4:50 AM
• Mattflaschen-WMF raised the priority of this task from to High.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added projects: Collaboration-Team-Triage, MediaWiki-extensions-MoodBar, StructuredDiscussions.
• Mattflaschen-WMF added subscribers: Aklapper, Unknown Object (MLST), greg and 6 others.
• Mattflaschen-WMF mentioned this in T85022: Audit deployed Collaboration team extensions for jQuery 1.11 upgrade issues.Dec 30 2014, 5:03 AM
Nikerabbit unsubscribed.Dec 30 2014, 8:09 AM
• Mattflaschen-WMF mentioned this in T85300: Don't use jQuery's live method in MoodBar.Jan 5 2015, 7:33 PM
gerritbot added a project: Patch-For-Review.Jan 5 2015, 7:47 PM

Change 182868 had a related patch set uploaded (by Mattflaschen):
Fix dashboard links that are visible on hover

https://gerrit.wikimedia.org/r/182868

Patch-For-Review

gerritbot added a comment.Jan 5 2015, 7:52 PM

Change 182868 merged by jenkins-bot:
Fix dashboard links that are visible on hover

https://gerrit.wikimedia.org/r/182868

• Mattflaschen-WMF mentioned this in rEMOOa02cb819de27: Fix dashboard links that are visible on hover.Jan 5 2015, 7:52 PM
Krenair removed a project: Patch-For-Review.Jan 5 2015, 8:00 PM
Krenair set Security to None.
gerritbot added a project: Patch-For-Review.Jan 5 2015, 8:13 PM

Change 182873 had a related patch set uploaded (by Mattflaschen):
Fix dashboard links that are visible on hover

https://gerrit.wikimedia.org/r/182873

Patch-For-Review

gerritbot added a comment.Jan 5 2015, 8:14 PM

Change 182874 had a related patch set uploaded (by Mattflaschen):
Fix dashboard links that are visible on hover

https://gerrit.wikimedia.org/r/182874

Patch-For-Review

• Mattflaschen-WMF claimed this task.Jan 5 2015, 8:18 PM
gerritbot added a comment.Jan 5 2015, 8:20 PM

Change 182873 merged by jenkins-bot:
Fix dashboard links that are visible on hover

https://gerrit.wikimedia.org/r/182873

• Mattflaschen-WMF mentioned this in rEMOO97c9a48fd5d7: Fix dashboard links that are visible on hover.Jan 5 2015, 8:20 PM
gerritbot added a comment.Jan 5 2015, 8:20 PM

Change 182874 merged by jenkins-bot:
Fix dashboard links that are visible on hover

https://gerrit.wikimedia.org/r/182874

• Mattflaschen-WMF mentioned this in rEMOO392d00803ee6: Fix dashboard links that are visible on hover.Jan 5 2015, 8:20 PM
gerritbot added a comment.Jan 5 2015, 8:21 PM

Change 182876 had a related patch set uploaded (by Mattflaschen):
Fix to use 'mouseenter mouseleave' instead of 'hover'

https://gerrit.wikimedia.org/r/182876

Patch-For-Review

• Mattflaschen-WMF moved this task from Untriaged to Code Review on the Collaboration-Team-Triage board.Jan 5 2015, 8:25 PM
matthiasmullie moved this task from Code Review to Product Review on the Collaboration-Team-Triage board.Jan 13 2015, 3:35 PM
gerritbot added a comment.Jan 13 2015, 3:35 PM

Change 182876 merged by jenkins-bot:
Fix to use 'mouseenter mouseleave' instead of 'hover'

https://gerrit.wikimedia.org/r/182876

• Mattflaschen-WMF mentioned this in rEFLW057d6418be7a: Fix to use 'mouseenter mouseleave' instead of 'hover'.Jan 13 2015, 3:35 PM
• Mattflaschen-WMF closed this task as Resolved.Jan 15 2015, 4:04 AM
RandomDSdevel awarded a token.Mar 4 2015, 7:04 PM
• Mattflaschen-WMF mentioned this in rMEXT44c7a64dc6e5: Updated mediawiki/extensions Project: mediawiki/extensions/MoodBar….Mar 11 2015, 6:23 AM
Diffusion mentioned this in rMEXT484a07a13bff: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL