Page MenuHomePhabricator

Edit source link broken after editing the page with VisualEditor
Closed, ResolvedPublic1 Estimated Story Points

Description

Seen as both anon and while logged in:

Edit any page at http://en.wikipedia.beta.wmflabs.org

Use insert menu to insert almost anything: I had the same experience with Formula, Table, and Media.

Save the page after inserting the element.

After save, click the wikitext edit link, whether logged in or anonymous. Nothing happens.

I see no javascript errors when clicking the wikitext edit, but I do see a warning on saving the page in VE, but I'm not sure it's relevant:

load.php:61
"Invalid _currentGuiderID. Returning early" load.php:153
console.trace(): load.php:154
mw.log</log.warn() load.php:154
transition/<()

Event Timeline

Cmcmahon raised the priority of this task from to Needs Triage.
Cmcmahon updated the task description. (Show Details)
Cmcmahon set Security to None.
Cmcmahon added a project: VisualEditor.
Cmcmahon added a subscriber: Etonkovidova.
Cmcmahon added a subscriber: Cmcmahon.

Change 181679 had a related patch set uploaded (by Alex Monk):
Don't break "Edit source" link after VE has closed

https://gerrit.wikimedia.org/r/181679

Patch-For-Review

Krenair claimed this task.Dec 30 2014, 9:07 PM

Sounds like this is something I already spotted and uploaded a patch for.

Krenair renamed this task from Wikitext edit link broken after inserting anything via VE to Edit source link broken after editing the page with VE .Dec 30 2014, 9:08 PM

I just saw the patch, thanks!

Jdforrester-WMF renamed this task from Edit source link broken after editing the page with VE to Edit source link broken after editing the page with VisualEditor.Jan 5 2015, 12:09 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Jan 5 2015, 1:23 PM

Change 181679 merged by jenkins-bot:
Don't break "Edit source" link after VE has closed

https://gerrit.wikimedia.org/r/181679

Checked in betalbs - Edit source works after VE Save.