Page MenuHomePhabricator
Create Task
Maniphest T85582

Duplicated topics in some views (Unbreak Now)
Closed, ResolvedPublic
Actions

Description

A notification for "6 new topics" led me to
https://www.mediawiki.org/w/index.php?title=Talk:Beta_Features/Hovercards&topiclist_sortby=newest&fromnotif=1#flow-post-s5zkrn9nzud1ownz
this view contains repeated topics.

I can reproduce the problem if I visit the link with a second account, but not whilst logged-out.

The &topiclist_sortby=newest seems to be the troublesome bit.

Details

Commits
rEFLW57a031a7e4c5: TOC bug: duplicated topics in some views
Related Gerrit Patches:
mediawiki/extensions/Flow : masterTOC bug: duplicated topics in some views

Related Objects

Event Timeline

Quiddity created this task.Dec 31 2014, 1:49 AM
Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity added a project: StructuredDiscussions.
Quiddity added a subscriber: Quiddity.
• Mattflaschen-WMF triaged this task as Unbreak Now! priority.Dec 31 2014, 1:51 AM
• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.
DannyH added a project: Collaboration-Team-Triage.Jan 5 2015, 6:53 PM
DannyH set Security to None.
DannyH moved this task from Untriaged to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.
DannyH renamed this task from Duplicated topics in some views to Duplicated topics in some views (Unbreak Now).Jan 8 2015, 6:49 PM
EBernhardson added a subscriber: EBernhardson.Jan 8 2015, 9:05 PM

This is an issue we already noticed and fixed in the TOC branch. What happens is:

  1. User has default sort order set to 'updated'
  2. User requests page with sort order of 'newest'
  3. Auto-pagination does not tell the backend about sort order, so gets user default of 'recent'
  4. Duplicated topics are those that are on page 1 of 'newest' but page 2 of 'updated'

The patch in the TOC branch changes this so that auto-pagination tells the backend about the sort order.

• Mattflaschen-WMF assigned this task to EBernhardson.Jan 9 2015, 6:54 PM

There might be an additional aspect to fix, which Erik is working on.

gerritbot added a project: Patch-For-Review.Jan 9 2015, 9:39 PM

Change 183985 had a related patch set uploaded (by EBernhardson):
TOC bug: duplicated topics in some views

https://gerrit.wikimedia.org/r/183985

Patch-For-Review

gerritbot added a comment.Jan 13 2015, 11:03 PM

Change 183985 merged by jenkins-bot:
TOC bug: duplicated topics in some views

https://gerrit.wikimedia.org/r/183985

Aklapper added a comment.Jan 20 2015, 6:10 PM

This task has been "Unbreak Now!" priority since December 31. A patch was merged on January 13.

Flow team: What else is left to do here? Or shall this task be closed as resolved?

DannyH closed this task as Resolved.Jan 23 2015, 7:22 PM
DannyH lowered the priority of this task from Unbreak Now! to Medium.
DannyH moved this task from Product Review to Done (see also Status=Resolved) on the Collaboration-Team-Triage board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL