Maniphest T85582

Duplicated topics in some views (Unbreak Now)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Quiddity
	Dec 31 2014, 1:49 AM

Tags

Subscribers

• Mattflaschen-WMF

Tokens

"Like" token, awarded by RandomDSdevel.

Description

A notification for "6 new topics" led me to
https://www.mediawiki.org/w/index.php?title=Talk:Beta_Features/Hovercards&topiclist_sortby=newest&fromnotif=1#flow-post-s5zkrn9nzud1ownz
this view contains repeated topics.

Selection_002.png (972×1 px, 149 KB)

I can reproduce the problem if I visit the link with a second account, but not whilst logged-out.

The &topiclist_sortby=newest seems to be the troublesome bit.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Flow	master	+48 -32	TOC bug: duplicated topics in some views

Customize query in gerrit

Revisions and Commits

rEFLW extension-Flow
	rEFLW57a031a7e4c5 TOC bug: duplicated topics in some views

Related Objects

Mentioned In: T117973: Same topic displayed twice on a board
rMEXTf66baad2cc62: Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
rEFLWf02c6089f311: TOC bug: duplicated topics in some views

Event Timeline

Quiddity created this task.Dec 31 2014, 1:49 AM

Quiddity raised the priority of this task from to Needs Triage.

Quiddity updated the task description. (Show Details)

Quiddity added a project: StructuredDiscussions.

Quiddity added a subscriber: Quiddity.

• Mattflaschen-WMF triaged this task as Unbreak Now! priority.Dec 31 2014, 1:51 AM

• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.

DannyH added a project: Collaboration-Team-Triage.Jan 5 2015, 6:53 PM

DannyH set Security to None.

DannyH moved this task from Untriaged to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.

DannyH renamed this task from Duplicated topics in some views to Duplicated topics in some views (Unbreak Now).Jan 8 2015, 6:49 PM

This is an issue we already noticed and fixed in the TOC branch. What happens is:

User has default sort order set to 'updated'
User requests page with sort order of 'newest'
Auto-pagination does not tell the backend about sort order, so gets user default of 'recent'
Duplicated topics are those that are on page 1 of 'newest' but page 2 of 'updated'

The patch in the TOC branch changes this so that auto-pagination tells the backend about the sort order.

There might be an additional aspect to fix, which Erik is working on.

EBernhardson moved this task from Sprint O (ends Jan 27) to In Development on the Collaboration-Team-Triage board.Jan 9 2015, 9:34 PM

Change 183985 had a related patch set uploaded (by EBernhardson):
TOC bug: duplicated topics in some views

https://gerrit.wikimedia.org/r/183985

Patch-For-Review

EBernhardson moved this task from In Development to Code Review on the Collaboration-Team-Triage board.Jan 9 2015, 9:40 PM

Change 183985 merged by jenkins-bot:
TOC bug: duplicated topics in some views

https://gerrit.wikimedia.org/r/183985

EBernhardson mentioned this in rEFLWf02c6089f311: TOC bug: duplicated topics in some views.Jan 13 2015, 11:03 PM

• Mattflaschen-WMF moved this task from Code Review to Product Review on the Collaboration-Team-Triage board.Jan 13 2015, 11:04 PM

Liuxinyu970226 added a subscriber: Liuxinyu970226.Jan 16 2015, 8:49 AM

This task has been "Unbreak Now!" priority since December 31. A patch was merged on January 13.

Flow team: What else is left to do here? Or shall this task be closed as resolved?

DannyH closed this task as Resolved.Jan 23 2015, 7:22 PM

DannyH lowered the priority of this task from Unbreak Now! to Medium.

DannyH moved this task from Product Review to Done (see also Status=Resolved) on the Collaboration-Team-Triage board.

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Jan 23 2015, 11:40 PM

Diffusion mentioned this in rMEXTf66baad2cc62: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:24 AM

RandomDSdevel awarded a token.Mar 29 2015, 10:21 PM

Quiddity mentioned this in T117973: Same topic displayed twice on a board.Apr 11 2016, 10:03 PM

• Mattflaschen-WMF added a commit: rEFLW57a031a7e4c5: TOC bug: duplicated topics in some views.Apr 28 2016, 2:40 AM