entry point
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• Elitre
	Dec 31 2014, 3:47 PM

Description

VEdit https://en.wikipedia.org/w/index.php?title=Tracey_Ferguson&veaction=edit .
Find the word "operation", and try to make that a wikilink to "operate".
Notice the dropdown features both "operate" and "Operate", but you need to choose the former to see the bug.
After you've selected this target, try to click on Open.
Notice you've been brought to the non existent "Operat" article (in some cases instead you'll be brought to the "former" target, "operation").
Notice everything is fine instead if you select words starting with a capital letter in the first place.

Details

	Subject	Repo	Branch	Lines +/-
	MWInternalLinkAnnotationWidget: Force 'Open' button to use full path	mediawiki/extensions/VisualEditor	master	+8 -0
	Link inspector: Set href of open button to new value, not old.	VisualEditor/VisualEditor	master	+3 -4

Customize query in gerrit

Related Objects

Mentioned In: T95136: Copying link makes it relative to edited page
rEVEDc0de5f2f516c: MWInternalLinkAnnotationWidget: Force 'Open' button to use full path
T85622: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and context menu and so fail to go anywhere
Mentioned Here: T76398: External link interface for link dialogue
T85622: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and context menu and so fail to go anywhere

Event Timeline

• Elitre created this task.Dec 31 2014, 3:47 PM

• Elitre raised the priority of this task from to Needs Triage.

• Elitre updated the task description. (Show Details)

• Elitre added a project: VisualEditor.

• Elitre subscribed.

Ricordisamoa subscribed.Dec 31 2014, 4:16 PM

• Elitre mentioned this in T85622: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and context menu and so fail to go anywhere.Dec 31 2014, 4:20 PM

Reproducible

select 'operation'(placing a cursor there is enough)
clear pre-filled 'operation' in the link inspector or just delete some letters and type to 'operate'

Notice that 'Open' button will redirect to <a class="oo-ui-buttonElement-button" role="button" tabindex="0" href="/wiki/Operat" target="_blank">Open</a>

It seems to "discriminate" between upper and lower cases:

typing 'Operate' will not have a suggestion 'operate' in the drop-down list
once 'Operate' is selected, it'll stick - trying to select 'operate' or change 'Operate' to 'operate' by re-typing in the link inspector - will not change the Open button target for 'Operate'

I also checked T85622 - since Bonjour has suggestions for 'Bonjour' and 'bonjour' - did not notice any discrepancies in re-directing.

Krenair subscribed.Jan 1 2015, 11:31 PM

Looks like the href of the open button is not getting updated as much as the contents of the input box changes.

It does get updated, but it's always a step behind... Interesting.

Change 182432 had a related patch set uploaded (by Alex Monk):
Link inspector: Set href of open button to new value, not old.

https://gerrit.wikimedia.org/r/182432

Patch-For-Review

Krenair claimed this task.Jan 2 2015, 5:32 AM

Jdforrester-WMF triaged this task as High priority.Jan 5 2015, 12:05 PM

Jdforrester-WMF added projects: VisualEditor-EditingTools, VisualEditor-MediaWiki-Links.

Jdforrester-WMF set Security to None.

Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.Jan 5 2015, 12:09 PM

Jdforrester-WMF lowered the priority of this task from High to Medium.Jan 15 2015, 12:15 AM

Jdforrester-WMF moved this task from Blocked to TR6: Visual diffs on the VisualEditor board.Feb 10 2015, 8:48 PM

Change 182432 abandoned by Alex Monk:
Link inspector: Set href of open button to new value, not old.

https://gerrit.wikimedia.org/r/182432

After posting my comments about what I was trying to fix in the commit above, I realise I may have been actually chasing a separate bug, and this is breaking things in a different way. Still something we need to fix though.

Actually it sounds like the issue I've been trying to deal with is this part:

in some cases instead you'll be brought to the "former" target, "operation"

Unfortunately properly picking up whether the typed text is for an external or internal link quick enough without waiting for the request to go through, menu to display, etc. would rely on T76398

Jdforrester-WMF removed a project: Patch-For-Review.May 8 2015, 1:40 AM

Jdforrester-WMF renamed this task from "Open" button in the Link tool can sometimes lead to a broken or incorrect target to "Open" button in the Link tool lead to a broken or incorrect target if on a /w/ entry point.Jun 18 2015, 12:50 AM

Jdforrester-WMF moved this task from TR6: Visual diffs to Needs Discussion/Analysis on the VisualEditor board.

Jdforrester-WMF added a project: VisualEditor 2015/16 Q1 blockers.Jun 18 2015, 10:18 PM

Jdforrester-WMF edited a custom field.Jun 18 2015, 10:44 PM

Krenair claimed this task.Jun 23 2015, 9:09 PM

Change 220307 had a related patch set uploaded (by Alex Monk):
Force 'Open' button for internal links to use full path

https://gerrit.wikimedia.org/r/220307

gerritbot added a project: Patch-For-Review.Jun 23 2015, 9:09 PM

Jdforrester-WMF moved this task from Nominated to Backlog: T1 on the VisualEditor 2015/16 Q1 blockers board.Jun 30 2015, 7:15 PM

Change 220307 merged by jenkins-bot:
MWInternalLinkAnnotationWidget: Force 'Open' button to use full path

https://gerrit.wikimedia.org/r/220307

Jdforrester-WMF mentioned this in rEVEDc0de5f2f516c: MWInternalLinkAnnotationWidget: Force 'Open' button to use full path.Jul 2 2015, 10:39 PM

• Forrestbot added a project: WMF-deploy-2015-07-07_(1.26wmf13).Jul 2 2015, 11:00 PM