Page MenuHomePhabricator

[Spike 2 hours] GalleryActivity does not animate animated gif
Closed, ResolvedPublic

Description

See https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8053825
The Jupiter article, in the Orbit and rotation section, shows this. The image animates fine until you tap it, then a limited description page shows where the image does not move.

This task is for investigating the plausibility of implementing animated gifs in our app.

Event Timeline

Krenair raised the priority of this task from to Needs Triage.
Krenair updated the task description. (Show Details)
Krenair added a subscriber: Krenair.
Deskana renamed this task from Animated images freeze when you tap them to GalleryActivity does not animate gifs.Jan 4 2015, 7:40 PM
Deskana set Security to None.
jeremyb-phone renamed this task from GalleryActivity does not animate gifs to GalleryActivity does not animate animated gifs.Apr 7 2015, 6:32 AM
jeremyb-phone added a subscriber: jeremyb.
jeremyb-phone renamed this task from GalleryActivity does not animate animated gifs to GalleryActivity does not animate animated gif.Apr 7 2015, 6:34 AM

ImageGallery does not display animation -couple of more examples to check: 'Caridoid escape reaction', 'Lilac chaser'.

Dbrant renamed this task from GalleryActivity does not animate animated gif to [Spike] GalleryActivity does not animate animated gif.Sep 17 2015, 7:51 PM
Dbrant updated the task description. (Show Details)
MBinder_WMF renamed this task from [Spike] GalleryActivity does not animate animated gif to [Spike 2 hours] GalleryActivity does not animate animated gif.Sep 25 2015, 5:51 PM

@Etonkovidova, thanks for the extra examples.

@devs, here's what I found:

  • Picasso: No support planned[0].
  • android-gif-drawable[1]: I'm not sure how compatible this is with Picasso and it has an NDK dependency :| However, it appears to be built against all ABIs.
  • android.graphics.Movie: There seems to be a general consensus that Movie is flaky and not well supported.
  • WebView: a good backup plan.
  • Ion[2]: by koush. Works for all examples but overlaps responsibilities with Picasso. There's no way to save an animated image, possibly any image, downloaded into the ImageView[3]. However, we might be able to snag it with a little more footwork[4].
  • gifanimateddrawable[4]: inactive.

I recommend Ion and considering a project wide replacement of Picasso if it works well.

[0] https://github.com/square/picasso/issues/1058
[1] https://github.com/koral--/android-gif-drawable
[2] https://github.com/koush/ion
[3] https://github.com/koush/ion/issues/250
[4] https://github.com/koush/ion/issues/148
[5] https://github.com/Hipmob/gifanimateddrawable