Page MenuHomePhabricator
Create Task
Maniphest T85784

LivePreview should not replace title message with displaytitle value in firstHeading
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

Actual result: The firstHeading contains "Wikipedia:Sandbox".
Expected result: The firstHeading contains "Editing Wikipedia:Sandbox".

Details

SubjectRepoBranchLines +/-
mediawiki.action.edit.preview: Replace only title in firstHeadingmediawiki/coremaster+7 -3
LivePreview: displaytitle updates only the title of the firstHeadingmediawiki/coremaster+9 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Fomafix created this task.Jan 5 2015, 10:04 AM
Fomafix claimed this task.
Fomafix raised the priority of this task from to Medium.
Fomafix updated the task description. (Show Details)
Fomafix added projects: JavaScript, MediaWiki-Page-editing.
Fomafix subscribed.
gerritbot added a project: Patch-For-Review.Jan 5 2015, 10:52 AM

Change 182780 had a related patch set uploaded (by Gerrit Patch Uploader):
mediawiki.action.edit.preview: Replace only title in firstHeading

https://gerrit.wikimedia.org/r/182780

Patch-For-Review

gerritbot added a comment.Jan 5 2015, 1:15 PM

Change 182794 had a related patch set uploaded (by Gerrit Patch Uploader):
LivePreview: displaytitle updates only the title of the firstHeading

https://gerrit.wikimedia.org/r/182794

Patch-For-Review

Krinkle renamed this task from LivePreview: Displaytitle replaces FirstHeading instead of title in FirstHeading to LivePreview should not replace tilte message with displaytitle value in in firstHeading.Jan 5 2015, 1:57 PM
Krinkle updated the task description. (Show Details)
Krinkle set Security to None.
Krinkle added a subscriber: TheDJ.
Fomafix renamed this task from LivePreview should not replace tilte message with displaytitle value in in firstHeading to LivePreview should not replace title message with displaytitle value in in firstHeading.Jan 5 2015, 2:22 PM
Fomafix added a subtask: T41272: Bugs in "Live preview" feature (tracking).Jan 5 2015, 2:25 PM
Fomafix renamed this task from LivePreview should not replace title message with displaytitle value in in firstHeading to LivePreview should not replace title message with displaytitle value in firstHeading.Jan 11 2015, 4:37 PM
Fomafix removed a subtask: T41272: Bugs in "Live preview" feature (tracking).Jan 26 2015, 9:57 AM
Fomafix added a parent task: T41272: Bugs in "Live preview" feature (tracking).
TheDJ added a comment.Mar 17 2015, 9:13 AM

Isn't it better to solve this similar to T88117 ?

Fomafix added a comment.Mar 17 2015, 5:20 PM
In T85784#1124418, @TheDJ wrote:

Isn't it better to solve this similar to T88117 ?

When https://gerrit.wikimedia.org/r/187710 is merged this solution can integrated in https://gerrit.wikimedia.org/r/182780

When the (display)title in all headings gets wrapped by a special element the solution from https://gerrit.wikimedia.org/r/182794 can used.

gerritbot subscribed.Mar 17 2015, 5:29 PM

Change 182794 abandoned by Krinkle:
LivePreview: displaytitle updates only the title of the firstHeading

Reason:
In favour of I71098997ae4.

https://gerrit.wikimedia.org/r/182794

TheDJ added a comment.Mar 24 2015, 10:51 PM

@Fomafix I've merged the one, so you can now amend the other to that solution.

Fomafix added a comment.Mar 25 2015, 5:47 AM

Done in Patch Set 5.

gerritbot added a comment.Mar 26 2015, 12:27 AM

Change 182780 merged by jenkins-bot:
mediawiki.action.edit.preview: Replace only title in firstHeading

https://gerrit.wikimedia.org/r/182780

Fomafix mentioned this in rMW3526b98d2e89: mediawiki.action.edit.preview: Replace only title in firstHeading.Mar 26 2015, 12:28 AM
TheDJ closed this task as Resolved.Mar 26 2015, 12:30 AM
TheDJ removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL