Steps to reproduce:
1.Open a page with VE
2.Insert an image with a caption
3.Now re-open the media settings dialog again
4.While the cursor is at the first index of the dialog,click on the link inspector icon and apply a link to the caption
Observed Result:
The "Apply Changes" button in the media settings dialog does not get enabled.
This only happens to new images, and it's extremely weird. This bug previously happened to *all* images, then it was fixed (I believe by Roan's correction to inspectors) and now it works for existing images and fails on new images.
It seems like we have a difference with the way the document is defined to new images, but the caption document saves correctly when the changes are applied.
Change 183303 had a related patch set uploaded (by Mooeypoo):
Check staged changes in surface hasBeenModified
This is an issue with the way the surface calculates its "hasBeenModified" state, and it happens also in citations (same bug)
We need to find a way to have the surface account for staged transactions (which mean changes from inspectors) so dialogs can enable the "Apply" button when links or language annotations are applied to text inside the surface widget.
Change 184409 had a related patch set uploaded (by Mooeypoo):
SurfaceWidgets should listen to history
Change 183303 abandoned by Mooeypoo:
Check staged changes in surface hasBeenModified
Reason:
Fixed in ve-mw instead