Page MenuHomePhabricator
Create Task
Maniphest T85854

Scribunto unit tests failing due to MediaWiki core changes
Closed, ResolvedPublic
Actions

Description

  • Gerrit change 142974 caused Language::fetchLanguageNames() to use 'en' rather than null when given an invalid language code. This didn't break Jenkins since, without cldr, it always uses null anyway.
  • Gerrit change 177980 (and Gerrit change 177979) caused Language::listToText() to start encoding single-quotes in messages such as 'and'.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update unit tests for recent core changesAnomiemediawiki/extensions/Scribuntomaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

Anomie created this task.Jan 5 2015, 8:52 PM
Anomie changed the task status from Open to Stalled.
Anomie claimed this task.
Anomie raised the priority of this task from to Medium.
Anomie updated the task description. (Show Details)
Anomie added projects: Scribunto, MediaWiki-Core-Team, MediaWiki-Internationalization.
Anomie subscribed.

Stalled on the question of whether the change to Language::listToText() should be reverted or not.

Anomie set Security to None.Jan 5 2015, 8:53 PM
Anomie moved this task from Backlog to Needs Review/Feedback on the MediaWiki-Core-Team board.
Anomie added subscribers: Jackmcbarn, Nikerabbit.
gerritbot added a project: Patch-For-Review.Jan 5 2015, 10:09 PM

Change 182099 had a related patch set uploaded (by Anomie):
Update unit tests for recent core changes

https://gerrit.wikimedia.org/r/182099

Patch-For-Review

Umherirrender subscribed.Jan 6 2015, 4:19 PM
• tstarling moved this task from Needs Review/Feedback to Done on the MediaWiki-Core-Team board.Jan 8 2015, 11:24 PM
gerritbot added a comment.Jan 8 2015, 11:29 PM

Change 182099 merged by jenkins-bot:
Update unit tests for recent core changes

https://gerrit.wikimedia.org/r/182099

• tstarling mentioned this in rELUAccfcbfc17f6a: Update unit tests for recent core changes.Jan 8 2015, 11:29 PM
Anomie closed this task as Resolved.Jan 9 2015, 2:08 PM
• bd808 moved this task from Done to Archive on the MediaWiki-Core-Team board.Jan 12 2015, 11:37 PM
Anomie mentioned this in rMEXT4c3a6d05d0c1: Updated mediawiki/extensions Project: mediawiki/extensions/Scribunto….Mar 11 2015, 6:23 AM
RandomDSdevel awarded a token.Mar 29 2015, 11:06 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits