Page MenuHomePhabricator
Create Task
Maniphest T85876

jscs should apply to test files as well.
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/182940 reveals 2008 code style errors in our test files. These should be fixed and the rule should be turned on here before this escalates any further!

Note some of these errors are documentation related - we shouldn't have to document test files so these should not be dealt with.

Details

SubjectRepoBranchLines +/-
Update how jscs runs on the test filesmediawiki/extensions/MobileFrontendmaster+18 -5
Hygiene: Enable jscs for test filesmediawiki/extensions/MobileFrontendmaster+4 -1
Hygiene: Apply jscs rules to search, talk, references testsmediawiki/extensions/MobileFrontendmaster+165 -147
Hygiene" Apply jscs to specials test filemediawiki/extensions/MobileFrontendmaster+15 -14
Hygiene: Apply jscs rules to wikigrok,lists,watchstar testsmediawiki/extensions/MobileFrontendmaster+270 -196
Hygiene: Apply jscs to toggling and uploads testsmediawiki/extensions/MobileFrontendmaster+452 -379
Hygiene: Apply jscs to mediaViewer,nearby,preferred languages testsmediawiki/extensions/MobileFrontendmaster+207 -94
Hygiene: Apply jscs to editor, issues, language, lastEditedmediawiki/extensions/MobileFrontendmaster+383 -193
Hygiene: Apply jscs to first level test filesmediawiki/extensions/MobileFrontendmaster+614 -404
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jan 5 2015, 10:35 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson subscribed.
Jdlrobson updated the task description. (Show Details)Jan 5 2015, 11:05 PM
Jdlrobson set Security to None.
Krenair subscribed.Jan 6 2015, 12:26 AM
kaldari moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Jan 7 2015, 6:53 PM
• bmansurov claimed this task.Jan 8 2015, 1:55 AM
gerritbot added a project: Patch-For-Review.Jan 8 2015, 2:26 AM

Change 183412 had a related patch set uploaded (by Bmansurov):
WIP: Apply jscs to test files

https://gerrit.wikimedia.org/r/183412

Patch-For-Review

gerritbot added a comment.Jan 8 2015, 5:21 PM

Change 183538 had a related patch set uploaded (by Bmansurov):
Apply jscs to some module test file

https://gerrit.wikimedia.org/r/183538

Patch-For-Review

gerritbot added a comment.Jan 8 2015, 7:00 PM

Change 183559 had a related patch set uploaded (by Bmansurov):
Apply jscs to some module test file

https://gerrit.wikimedia.org/r/183559

Patch-For-Review

gerritbot added a comment.Jan 8 2015, 7:08 PM

Change 183562 had a related patch set uploaded (by Bmansurov):
Apply jscs to some module test file

https://gerrit.wikimedia.org/r/183562

Patch-For-Review

gerritbot added a comment.Jan 8 2015, 7:16 PM

Change 183565 had a related patch set uploaded (by Bmansurov):
Apply jscs to some module test file

https://gerrit.wikimedia.org/r/183565

Patch-For-Review

gerritbot added a comment.Jan 8 2015, 7:27 PM

Change 183570 had a related patch set uploaded (by Bmansurov):
Apply jscs to some module test file

https://gerrit.wikimedia.org/r/183570

Patch-For-Review

gerritbot added a comment.Jan 8 2015, 7:30 PM

Change 183602 had a related patch set uploaded (by Bmansurov):
Apply jscs to specials test file

https://gerrit.wikimedia.org/r/183602

Patch-For-Review

• bmansurov moved this task from 2015-16 Q4 to Needs Prioritization on the Web-Team-Backlog board.Jan 8 2015, 7:39 PM
gerritbot added a comment.Jan 9 2015, 2:35 PM

Change 183854 had a related patch set uploaded (by Phuedx):
Run JSCS agains the test files

https://gerrit.wikimedia.org/r/183854

Patch-For-Review

gerritbot added a comment.Jan 9 2015, 5:34 PM

Change 183412 merged by jenkins-bot:
Hygiene: Apply jscs to first level test files

https://gerrit.wikimedia.org/r/183412

Jdlrobson mentioned this in rEMFR18dfbf59143d: Hygiene: Apply jscs to first level test files.Jan 9 2015, 5:35 PM
gerritbot added a comment.Jan 9 2015, 5:36 PM

Change 183538 merged by jenkins-bot:
Hygiene: Apply jscs to editor, issues, language, lastEdited

https://gerrit.wikimedia.org/r/183538

Jdlrobson mentioned this in rEMFR5684447a805c: Hygiene: Apply jscs to editor, issues, language, lastEdited.Jan 9 2015, 5:37 PM
gerritbot added a comment.Jan 9 2015, 5:39 PM

Change 183559 merged by jenkins-bot:
Hygiene: Apply jscs to mediaViewer,nearby,preferred languages tests

https://gerrit.wikimedia.org/r/183559

Jdlrobson mentioned this in rEMFR6d0ad3f959b2: Hygiene: Apply jscs to mediaViewer,nearby,preferred languages tests.Jan 9 2015, 5:39 PM
gerritbot added a comment.Jan 9 2015, 5:42 PM

Change 183565 merged by jenkins-bot:
Hygiene: Apply jscs to toggling and uploads tests

https://gerrit.wikimedia.org/r/183565

Jdlrobson mentioned this in rEMFRbd0fd74fce3b: Hygiene: Apply jscs to toggling and uploads tests.Jan 9 2015, 5:42 PM
gerritbot added a comment.Jan 9 2015, 5:43 PM

Change 183570 merged by jenkins-bot:
Hygiene: Apply jscs rules to wikigrok,lists,watchstar tests

https://gerrit.wikimedia.org/r/183570

Jdlrobson mentioned this in rEMFRc5f3305a12b4: Hygiene: Apply jscs rules to wikigrok,lists,watchstar tests.Jan 9 2015, 5:43 PM
gerritbot added a comment.Jan 9 2015, 5:44 PM

Change 183602 merged by jenkins-bot:
Hygiene" Apply jscs to specials test file

https://gerrit.wikimedia.org/r/183602

Jdlrobson mentioned this in rEMFR0571299363f6: Hygiene" Apply jscs to specials test file.Jan 9 2015, 5:44 PM
gerritbot added a comment.Jan 9 2015, 6:28 PM

Change 183413 had a related patch set uploaded (by Bmansurov):
Hygiene: Enable jscs for test files

https://gerrit.wikimedia.org/r/183413

Patch-For-Review

gerritbot added a comment.Jan 9 2015, 8:35 PM

Change 183562 merged by jenkins-bot:
Hygiene: Apply jscs rules to search, talk, references tests

https://gerrit.wikimedia.org/r/183562

• bmansurov mentioned this in rEMFRe127aaa6ae6f: Hygiene: Apply jscs rules to search, talk, references tests.Jan 9 2015, 8:35 PM
Jdlrobson closed this task as Resolved.Jan 9 2015, 8:36 PM
gerritbot added a comment.Jan 9 2015, 8:36 PM

Change 183413 merged by jenkins-bot:
Hygiene: Enable jscs for test files

https://gerrit.wikimedia.org/r/183413

Jdlrobson mentioned this in rEMFR33fe51c3722d: Hygiene: Enable jscs for test files.Jan 9 2015, 8:37 PM
gerritbot added a comment.Jan 12 2015, 6:36 PM

Change 183854 merged by jenkins-bot:
Update how jscs runs on the test files

https://gerrit.wikimedia.org/r/183854

Jdlrobson mentioned this in rEMFRd94b89433703: Update how jscs runs on the test files.Jan 12 2015, 6:36 PM
• bmansurov mentioned this in rMEXT5b07d200206e: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:23 AM
• bmansurov mentioned this in rMEXT8509c2f12e86: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
• bmansurov mentioned this in rMEXT3928f56cecce: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
Diffusion mentioned this in rMEXT67641154ec68: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:23 AM
Diffusion mentioned this in rMEXTa0460f7f3c87: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
Diffusion mentioned this in rMEXTb33a273ca86c: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
Diffusion mentioned this in rMEXT2cbb7c7af7ea: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
Diffusion mentioned this in rMEXTc9808009d7f5: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
• bmansurov mentioned this in rMEXT19466eec2100: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:24 AM
RandomDSdevel awarded a token.Mar 29 2015, 10:45 PM
• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL