Page MenuHomePhabricator
Create Task
Maniphest T85890

Dismantle Mantle
Closed, ResolvedPublic
Actions

Description

Now templates are in core, there is very little reason for Mantle to exist.

For Flow:

  • Move the javascripts/templates/handlebars.js file into the Flow repository.

MobileFrontend:

Mantle [after Flow and MobileFrontend changes have been made]

Adding Zero in case this will have any impacts on them.

Once the above are done we should remove the dependency and deprecate the extension for the time being. We can always resurface it if needed.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Mantlemaster+4 -3 KRemove files so people know this extension is no longer active
operations/mediawiki-configmaster+0 -6Remove Mantle from configuration
mediawiki/tools/releasemaster+0 -1Remove Mantle from wmf-branch creation script
mediawiki/vagrantmaster+2 -10Remove Mantle; nothing requires it any more
mediawiki/extensions/Flowmaster+3 K -8DisMantle Mantle
mediawiki/extensions/MobileFrontendmaster+0 -6Remove Mantle dependency from MobileFrontend
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFlorianT93448 Remove Mantle from cluster
 ResolvedJdlrobsonT85890 Dismantle Mantle

Event Timeline

Jdlrobson created this task.Jan 5 2015, 11:55 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Readers-Web-Backlog, StructuredDiscussions, ZeroBanner.
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson added a subscriber: Jdlrobson.
Krenair added a subscriber: Krenair.Jan 6 2015, 12:24 AM
• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.Jan 6 2015, 12:56 AM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.Jan 6 2015, 7:30 PM
• Tfinc added a subscriber: • Tfinc.Jan 6 2015, 7:44 PM
Quiddity added a project: Scrum-of-Scrums.Jan 7 2015, 6:49 PM
• Spage added a project: UI-Standardization.Jan 8 2015, 5:51 AM
• Spage added a subscriber: • Spage.

Flow uses Lightncandy to deliver handlebars templates, but as I understand it the UI-Standardization effort is only adding mustache support to core (T330: Choose a standard template language doesn't say). Mobile and Flow may need to run local code to keep their Hogan and handlebars templates working, respectively.

gerritbot added a project: Patch-For-Review.Jan 9 2015, 9:19 PM

Change 183977 had a related patch set uploaded (by Jdlrobson):
Remove Mantle dependency from MobileFrontend

https://gerrit.wikimedia.org/r/183977

Patch-For-Review

Jdforrester-WMF added a subscriber: Jdforrester-WMF.Jan 12 2015, 9:13 PM
Florian added a subscriber: Florian.Jan 12 2015, 9:48 PM
Ricordisamoa added a subscriber: Ricordisamoa.Jan 12 2015, 10:03 PM
gerritbot added a comment.Jan 13 2015, 1:05 AM

Change 183977 merged by jenkins-bot:
Remove Mantle dependency from MobileFrontend

https://gerrit.wikimedia.org/r/183977

Jdlrobson mentioned this in rEMFR9a53aa59473f: Remove Mantle dependency from MobileFrontend.Jan 13 2015, 1:05 AM
hashar added a subscriber: hashar.Jan 13 2015, 8:37 PM

Would it be possible to have Mantle skip loading when it detects it is run with a sufficiently recent version of mediawiki/core ?

Jdlrobson added a comment.Jan 13 2015, 8:58 PM

@hashar mobile is now not using Mantle for anything. The dependency has also been removed https://gerrit.wikimedia.org/r/183977 although it's harmless when it's side by side.

Removing mobile-web tag since now this is on the Flow team.

Jdlrobson removed a project: Readers-Web-Backlog.Jan 13 2015, 8:58 PM
• Mattflaschen-WMF renamed this task from Dismantle Mantle to Have Flow stop using Mantle.Jan 15 2015, 4:26 AM
• Mattflaschen-WMF triaged this task as Medium priority.
Jdlrobson added a comment.Mar 10 2015, 9:38 PM

Guys.. could you get this done? I'm really keen to stop supporting this extension. It's literally a copy and paste job and shouldn't take longer than 10 mins...

Diffusion mentioned this in rMEXT679946fc80ac: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:24 AM
• DannyH added a project: Collaboration-Team-Sprint-S-2015-03-25.Mar 12 2015, 12:57 AM
gerritbot added a subscriber: gerritbot.Mar 12 2015, 10:55 AM

Change 196195 had a related patch set uploaded (by Matthias Mullie):
Dismantle Mantle

https://gerrit.wikimedia.org/r/196195

matthiasmullie claimed this task.Mar 12 2015, 10:55 AM
matthiasmullie moved this task from Sprint S - ends March 25 to Needs Code Review on the Collaboration-Team-Sprint-S-2015-03-25 board.
EBernhardson moved this task from Needs Code Review to Code Review Started on the Collaboration-Team-Sprint-S-2015-03-25 board.Mar 12 2015, 4:19 PM
matthiasmullie closed this task as Resolved.Mar 16 2015, 1:54 PM
matthiasmullie moved this task from Code Review Started to Product Review on the Collaboration-Team-Sprint-S-2015-03-25 board.
matthiasmullie moved this task from Product Review to Done on the Collaboration-Team-Sprint-S-2015-03-25 board.
gerritbot added a comment.Mar 16 2015, 1:56 PM

Change 196195 merged by jenkins-bot:
DisMantle Mantle

https://gerrit.wikimedia.org/r/196195

matthiasmullie reopened this task as Open.Mar 16 2015, 1:59 PM

Probably shouldn't close this yet - anything else needs to happen with Mantle?

matthiasmullie renamed this task from Have Flow stop using Mantle to Dismantle Mantle.Mar 16 2015, 1:59 PM
matthiasmullie removed matthiasmullie as the assignee of this task.
matthiasmullie removed projects: Collaboration-Team-Sprint-S-2015-03-25, StructuredDiscussions.
matthiasmullie added a subscriber: matthiasmullie.
Jdlrobson added a subscriber: greg.Mar 20 2015, 9:12 PM

@greg @hashar we can remove Mantle from cluster and browser tests now - nothing is using it. How do we do this?

greg added a project: Wikimedia-Extension-setup.Mar 20 2015, 11:41 PM

https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Disabling_an_extension

matthiasmullie mentioned this in rEFLWe15704e731ad: DisMantle Mantle.Mar 23 2015, 3:53 PM
matthiasmullie mentioned this in rMEXT6f45de5465d1: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 23 2015, 3:55 PM
Yurik added a project: Zero.Mar 26 2015, 7:56 PM
• Mattflaschen-WMF removed a project: Wikimedia-Extension-setup.Mar 26 2015, 9:53 PM
• Mattflaschen-WMF added a subtask: T93448: Remove Mantle from cluster.
• Mattflaschen-WMF added a project: MediaWiki-extensions-Mantle.
RandomDSdevel awarded a token.Mar 29 2015, 10:43 PM
gerritbot added a comment.May 3 2015, 5:00 AM

Change 208496 had a related patch set uploaded (by Mattflaschen):
Remove Mantle; nothing requires it any more

https://gerrit.wikimedia.org/r/208496

gerritbot added a comment.May 4 2015, 3:51 PM

Change 208496 merged by jenkins-bot:
Remove Mantle; nothing requires it any more

https://gerrit.wikimedia.org/r/208496

• Mattflaschen-WMF mentioned this in rMWVA368f77526013: Remove Mantle; nothing requires it any more.May 4 2015, 4:01 PM
gerritbot added a comment.May 13 2015, 9:40 PM

Change 210816 had a related patch set uploaded (by Florianschmidtwelzow):
Remove Mantle from configuration

https://gerrit.wikimedia.org/r/210816

gerritbot added a comment.May 13 2015, 9:40 PM

Change 210817 had a related patch set uploaded (by Florianschmidtwelzow):
Remove Mantle from wmf-branch creation script

https://gerrit.wikimedia.org/r/210817

gerritbot added a comment.May 19 2015, 7:04 PM

Change 210817 merged by jenkins-bot:
Remove Mantle from wmf-branch creation script

https://gerrit.wikimedia.org/r/210817

Florian mentioned this in rMREL8bfd347d857c: Remove Mantle from wmf-branch creation script.May 19 2015, 7:04 PM
Krenair added a comment.May 24 2015, 12:03 PM

So it's no longer being branched, but is still in WMF config. Can this be finished off?

Krenair mentioned this in T93448: Remove Mantle from cluster.May 24 2015, 12:03 PM
Krenair mentioned this in T87938: Convert Mantle to use extension registration.
Jdlrobson closed this task as Resolved.May 24 2015, 12:34 PM
Jdlrobson claimed this task.
Krenair removed a subtask: T93448: Remove Mantle from cluster.May 24 2015, 1:18 PM
Krenair added a parent task: T93448: Remove Mantle from cluster.
gerritbot added a comment.May 27 2015, 7:27 PM

Change 210816 merged by jenkins-bot:
Remove Mantle from configuration

https://gerrit.wikimedia.org/r/210816

Florian mentioned this in rOMWC5f398b2cf50e: Remove Mantle from configuration.May 27 2015, 7:28 PM
Krenair mentioned this in T71916: Namespacing templates.Jun 2 2015, 10:49 PM
Krenair mentioned this in T71034: Break out Makefile / dev-scripts into separate repository.
Krenair mentioned this in T68360: Mantle compiles all handlebars templates on initial load.
Krenair mentioned this in T68099: Remove default template compiler.
Krenair mentioned this in T66735: Mantle: support handlebars compilation.
gerritbot added a comment.Jun 2 2015, 10:52 PM

Change 215538 had a related patch set uploaded (by Mattflaschen):
Remove files so people know this extension is no longer active

https://gerrit.wikimedia.org/r/215538

• Mattflaschen-WMF reopened this task as Open.Jun 2 2015, 10:54 PM

Would be good to get that last commit merged, so people know this isn't an active extension they have to maintain.

gerritbot added a comment.Jun 3 2015, 6:51 AM

Change 215538 merged by jenkins-bot:
Remove files so people know this extension is no longer active

https://gerrit.wikimedia.org/r/215538

• Mattflaschen-WMF mentioned this in rMEXTe53cc78584aa: Updated mediawiki/extensions Project: mediawiki/extensions/Mantle….Jun 3 2015, 6:51 AM
Ricordisamoa closed this task as Resolved.Jun 3 2015, 7:03 AM
Ricordisamoa removed a project: Patch-For-Review.

Dismantled.

• Mattflaschen-WMF mentioned this in rEMANa2885d306f71: Remove files so people know this extension is no longer active.Jun 3 2015, 7:30 AM
hashar mentioned this in rCICF4ee3510a8260: Remove Mantle from dependency tree for several extensions.Jul 20 2015, 7:48 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL