Mobile VisualEditor won't load (this.getSurface(...) is undefined)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently on test.wiki or mediawiki.org if you try to load the VisualEditor by switching to it, it fails with the error message:
"this.getSurface(...) is undefined"

The trace points to ve.ui.Toolbar.js (line 224, col 8):
return this.getSurface().triggerListener.getCommands();

Running in beta mode as a logged in user. Couldn't test on Beta Labs due to Parsiod issues there.

Details

	Subject	Repo	Branch	Lines +/-
	Update setupToolbar signature in mobile target	mediawiki/extensions/VisualEditor	wmf/1.25wmf13	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: rEVED987314ce8a4d: Update setupToolbar signature in mobile target
T85480: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing
T84897: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web

Event Timeline

kaldari created this task.Jan 6 2015, 1:34 AM

kaldari raised the priority of this task from to High.

kaldari updated the task description. (Show Details)

kaldari added projects: VisualEditor, Web-Team-Backlog.

kaldari subscribed.

matmarex mentioned this in T84897: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web.Jan 6 2015, 2:06 AM

matmarex mentioned this in T85480: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing.

Mobile VE loads for me on beta, but not on mediawiki.org. By the way, we've already swatted two fixes for mobile VE today (see the mentions above).

Krenair subscribed.Jan 6 2015, 2:59 AM

Change 182993 had a related patch set uploaded (by Alex Monk):
Update setupToolbar signature in mobile target

https://gerrit.wikimedia.org/r/182993

Patch-For-Review

Looks like we missed one. See patch above.

Change 182993 merged by Catrope:
Update setupToolbar signature in mobile target

https://gerrit.wikimedia.org/r/182993

Krenair mentioned this in rEVED987314ce8a4d: Update setupToolbar signature in mobile target.Jan 6 2015, 4:14 PM

Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.Jan 6 2015, 4:21 PM

Jdforrester-WMF closed this task as Resolved.Jan 7 2015, 4:21 PM

Jdforrester-WMF added a project: WMF-deploy-2015-01-07_(1.25wmf14).

Jdforrester-WMF set Security to None.

Jdforrester-WMF added a project: WMF-deploy-2014-12-17_(1.25wmf13).

Jdforrester-WMF assigned this task to Krenair.Jan 7 2015, 9:19 PM

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.

Jdforrester-WMF removed a project: Patch-For-Review.Jan 7 2015, 9:25 PM

Etonkovidova added a project: Verified-in-Phase0.Jan 9 2015, 12:32 AM

Verified in en.wiki

Ryasmeen added a project: Verified-in-Phase2.Jan 15 2015, 10:58 PM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM

Jdforrester-WMF edited a custom field.Jan 23 2015, 11:55 PM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:02 PM

Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:32 PM

• Phabricator_maintenance moved this task from Incoming to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:29 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 7 2018, 4:29 AM

Mobile VisualEditor won't load (this.getSurface(...) is undefined)Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Mobile VisualEditor won't load (this.getSurface(...) is undefined)
Closed, ResolvedPublic1 Estimated Story Points
Actions