Page MenuHomePhabricator

Mobile VisualEditor won't load (this.getSurface(...) is undefined)
Closed, ResolvedPublic1 Story Points

Description

Currently on test.wiki or mediawiki.org if you try to load the VisualEditor by switching to it, it fails with the error message:
"this.getSurface(...) is undefined"

The trace points to ve.ui.Toolbar.js (line 224, col 8):
return this.getSurface().triggerListener.getCommands();

Running in beta mode as a logged in user. Couldn't test on Beta Labs due to Parsiod issues there.

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : wmf/1.25wmf13Update setupToolbar signature in mobile target

Event Timeline

kaldari created this task.Jan 6 2015, 1:34 AM
kaldari raised the priority of this task from to High.
kaldari updated the task description. (Show Details)
kaldari added a subscriber: kaldari.

Mobile VE loads for me on beta, but not on mediawiki.org. By the way, we've already swatted two fixes for mobile VE today (see the mentions above).

Krenair added a subscriber: Krenair.Jan 6 2015, 2:59 AM

Change 182993 had a related patch set uploaded (by Alex Monk):
Update setupToolbar signature in mobile target

https://gerrit.wikimedia.org/r/182993

Patch-For-Review

Looks like we missed one. See patch above.

Change 182993 merged by Catrope:
Update setupToolbar signature in mobile target

https://gerrit.wikimedia.org/r/182993

Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.

Verified in en.wiki

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 7 2018, 4:29 AM