Page MenuHomePhabricator

Update the php5 luasandbox package for trusty
Closed, InvalidPublic

Event Timeline

Gilles raised the priority of this task from to Medium.
Gilles updated the task description. (Show Details)
Gilles added a project: acl*sre-team.
Gilles added subscribers: Unknown Object (MLST), Anomie, dduvall and 13 others.

I just started looking at this. At a first glance it looks easy, but famous last words. I will update this once I have something to report

the php5-luasandbox package is already in apt.wikimedia.org for trusty... why should it be updated? which specific patches should be included?

The needed patch was Gerrit change 159757, which IIRC wasn't included in the 2.0-6 build that was available when T73354 was last looked at. But it looks like it is included in the 2.0-7+wmf2.1 build that is currently at http://apt.wikimedia.org/wikimedia/pool/main/p/php-luasandbox/.

@Gilles, when you rechecked T73354 did you make sure to get the latest version of php-luasandbox? Or is vagrant just doing "ensure present"?

If this is the case, we may just need to ensure all production is at the same update level.

Gilles claimed this task.

Indeed @Anomie it seems like the vagrant role didn't upgrade the package on its own, I had 2.0-7 installed, not 2.0-7+wmf2.1. Once updated via apt, the issue I was experiencing in T73354 went away.