Page MenuHomePhabricator

Disabling CodeEditor
Open, LowestPublic

Description

CodeEditor is still experimental and it's not working right with right to left languages, when you select right part of a code it selects wrong part of the code because of problem with right to left languages, it make us unable to use browser's search function, it has a huge load on our low speed internet, it sometimes crashes the browser, this time it made me really made because it removed wrong part of what I supposed to edit.

Please put an option so anyone don't like that can easily disable it.

Event Timeline

Mjbmr raised the priority of this task from to Needs Triage.
Mjbmr updated the task description. (Show Details)
Mjbmr subscribed.

Thanks for taking the time to report this!

If it has "a huge load" (what does that mean?), crashes (please provide steps to reproduce), or "crashes the browser" (please provide steps to reproduce, which browser?), please provide specific dedicated bug reports about that, following How to report a bug.
For the right to left languages part, please provide steps to reproduce that anybody else could follow without having to interpret any steps. Thanks in advance.

Of course I know how to report a bug, and please set me as the reporter of those bugs I've been reporting on bugzilla.

This extension is enabled on WMF projects, I'm just asking you put an option so I can disable it, that's it, it crashes my firefox browser just because I have a low performance computer and loads lots of js, css and I've to wait to load those files because of my low speed internet connection. I know these are my problems, it won't crash on fast computers at all, it won't have a problem on a fast speed internets at all, some people like using it specially when it makes us unable to use ctrl+F. but please put an option so I can disable it, you don't have time, alright I've four years of php experience, let me do it, I can easily put an option in Special:Preferences for it.

Aklapper triaged this task as Lowest priority.Jan 7 2015, 12:42 PM

[offtopic]

please set me as the reporter of those bugs I've been reporting on bugzilla.

See https://www.mediawiki.org/wiki/Phabricator/Help#Claiming_your_previous_Bugzilla_and_RT_accounts

ehm, there is button on the left of the toolbar to enable/disable at will.

@Aklapper I've been wait since my account is created, nothing happened yet.

@TheDJ Is there anyway to stop it loading into our browsers?

@Mjbmr The option is persisted in your user account.

If you hit that option, then it isn't loaded in your browser (or rather extremely minimally so), all the actual ACE code other then its startup loader is not downloaded. There is no way that the remaining code would still significantly slowdown your browser.

Disabling the entire enhanced toolbar in your preferences also removes those last traces.

[offtopic]

@Aklapper I've been wait since my account is created, nothing happened yet.

Please check whether the email address that you added in Phabricator has the same spelling (all lowercase: mjbmri@...) as the one you had in Bugzilla, and after making sure and waiting for 24 hours, please open a separate ticket against the "Phabricator" project. See T76169 for a potentially similar case. Thank you.

@TheDJ as I checked it still load into my browser I can totally see the delay.

Change 184290 had a related patch set uploaded (by Mjbmr):
Adding disable option: [[phab:T85959]]

https://gerrit.wikimedia.org/r/184290

Patch-For-Review

There is also https://gerrit.wikimedia.org/r/#/c/144780/ waiting to be review that may fix the problem. Not sure though.

I think a few issues are getting conflated here.

First, if CodeEditor doesn't support RTL languages, we should just disable CodeEditor automatically and by default for RTL languages. Users shouldn't need to opt out of broken software. (That said, I have no idea CodeEditor is actually broken in RTL languages, I write LTR.) Disabling CodeEditor for RTL langauges shouldn't require a new user preference, just a configuration tweak.

Second, CodeEditor already has a persistent disable toggle, as @TheDJ notes. This toggle should fully disable CodeEditor. If that isn't happening currently, then it makes sense to fix that toggle to do the right thing. Adding a new setting doesn't make sense to me.