Page MenuHomePhabricator

Remove .idea (PHPStorm project settings container) from Vagrant repo
Closed, ResolvedPublic

Description

I get dirty diffs, checkout conflicts etc. every time I change a setting in PHPStorm. If the goal is to enforce coding style, there must be a less annoying solution than this.

Event Timeline

Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added a project: MediaWiki-Vagrant.
Tgr subscribed.

CC Yuri and Max per git blame.

Maybe rename it to .idea-dist? Or save the code style to a separate file which can be selected via Code Style > Scheme, track that and .gitignore all other files in .idea?

The goal of vagrant is to have a ready-to-use env for new devs. If we could have a pre-made phpstorm dir with all useful settings, we would benefit many, at the cost of inconviniencing few. I have already submitted a few recomendations to phpstorm to make it more useful for our dev model, and more feedback is welcome. I don't think it is a good idea to have extra steps like attaching external syntax file (that many devs might miss).

Please comment or create new issues here:
https://youtrack.jetbrains.com/issue/IDEA-125019
https://youtrack.jetbrains.com/issue/IDEA-125009

Vagrant could create the .idea directory when it is initialized. The drawback is that if you set up the project in PHPStorm after checking out MW-Vagrant but before starting it, it will overwrite your project files (or abort, depending on how it is implemented) but I doubt many would do that.

Can we tell people to install the MediaWiki plugin for PHPStorm which should do all of this (and if it doesn't have it do that ;))?

bd808 triaged this task as Low priority.Jan 8 2015, 5:56 PM
bd808 subscribed.
gerritbot subscribed.

Change 187816 had a related patch set uploaded (by Gergő Tisza):
Stop git from tracking .idea (PHPStorm) directory

https://gerrit.wikimedia.org/r/187816

Patch-For-Review

Can we tell people to install the MediaWiki plugin for PHPStorm which should do all of this (and if it doesn't have it do that ;))?

See also T88149#1005961 for limitations of the current approach.

Change 187816 merged by jenkins-bot:
Stop git from tracking .idea (PHPStorm) directory

https://gerrit.wikimedia.org/r/187816

bd808 claimed this task.