Page MenuHomePhabricator
Create Task
Maniphest T85994

Update QUnit to 1.16.0
Closed, ResolvedPublic
Actions

Description

I'd love to have assert.expect available, which is included since 1.15.0 (we are on 1.14.0 currently). See Changelog. Files are available at https://github.com/jquery/qunit/tree/1.16.0/qunit.

Details

SubjectRepoBranchLines +/-
Update QUnit from v1.14.0 to v1.16.0mediawiki/coremaster+1 K -1 K
Customize query in gerrit

Related Objects

Event Timeline

adrianheine created this task.Jan 7 2015, 10:02 AM
adrianheine raised the priority of this task from to Low.
adrianheine updated the task description. (Show Details)
adrianheine added projects: JavaScript, Quality-Assurance.
adrianheine added subscribers: adrianheine, Krinkle, • TrevorParscal.
gerritbot added a project: Patch-For-Review.Jan 7 2015, 10:08 AM

Change 183217 had a related patch set uploaded (by Adrian Lang):
Upgrade QUnit from 1.14.0 to 1.16.0

https://gerrit.wikimedia.org/r/183217

Patch-For-Review

adrianheine updated the task description. (Show Details)Jan 7 2015, 10:08 AM
adrianheine set Security to None.

I realized that @Krinkle already changed the HTML, so the update is really straight-forward now.

Krinkle added a comment.Jan 7 2015, 3:19 PM

Note that assert.expect is not new. It's just been renamed. It was previously known as QUnit.expect and via QUnit.test( name, expect, callback ).

gerritbot added a comment.Jan 7 2015, 3:29 PM

Change 183217 merged by jenkins-bot:
Update QUnit from v1.14.0 to v1.16.0

https://gerrit.wikimedia.org/r/183217

Krinkle mentioned this in rMWedf91cda438c: Update QUnit from v1.14.0 to v1.16.0.Jan 7 2015, 3:29 PM
Krinkle closed this task as Resolved.Jan 7 2015, 3:34 PM
Krinkle assigned this task to adrianheine.
Krinkle edited projects, added MediaWiki-Core-Tests, MW-1.25-release; removed Patch-For-Review, Quality-Assurance.
adrianheine added a comment.Jan 8 2015, 8:06 AM
In T85994#959498, @Krinkle wrote:

Note that assert.expect is not new. It's just been renamed. It was previously known as QUnit.expect and via QUnit.test( name, expect, callback ).

Sure, I was talking about the up-to-date name, not the feature :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL