Page MenuHomePhabricator
Create Task
Maniphest T86032

PHP Notice: Undefined index: DataCollector.php on line 128
Closed, ResolvedPublic
Actions

Description

When uploading a file with the UploadWizard extension (d8090e9ad01dcdf098ebe2c47fa6421fbd2c947a of 2014-07-07 REL1_23) this extension (6b330e1407c9b68bc588b70c35474092eb32386b of 2014-06-03 beyond REL1_23) emits the following PHP notices for each information not provided e.g. coordinates, informationFields etc. I am using PHP 5.4 for an MW 1.23.8 instance

PHP Notice: Undefined index: coordinates in /.../extensions/CommonsMetadata/DataCollector.php on line 128, referer: https://www.example.com/wiki/Special:UploadWizard

Related Objects

Event Timeline

Kghbln created this task.Jan 7 2015, 6:14 PM
Kghbln raised the priority of this task from to Needs Triage.
Kghbln updated the task description. (Show Details)
Kghbln added a project: CommonsMetadata.
Kghbln subscribed.
Aklapper triaged this task as Low priority.Jan 7 2015, 9:28 PM
• Gilles added a project: Multimedia.Jan 8 2015, 9:28 AM
• Tgr added a project: good first task.Jan 9 2015, 1:15 AM
• Tgr subscribed.

This was fixed in https://gerrit.wikimedia.org/r/#/c/165476/ . REL1_23 is a long-term support release so that needs to be backported.

• Tgr added a project: MediaWiki-Tarball-Backports.Jan 11 2015, 2:03 AM
• Tgr removed a project: MediaWiki-Tarball-Backports.
• Tgr set Security to None.
• Tgr added a project: Google-Code-in-2014.Jan 11 2015, 2:40 AM

GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5864911406104576

• Tgr closed this task as Resolved.Jan 17 2015, 8:48 AM
• Tgr claimed this task.

The fix has been backported to 1.24.

• Tgr reassigned this task from • Tgr to Unicodesnowman.Jan 17 2015, 8:48 AM
Kghbln added a comment.Jan 17 2015, 9:28 AM

Great, thank you for dealing with this. What about REL1_23?

Unicodesnowman added a comment.Jan 17 2015, 9:34 AM

The code that causes this notice doesn't exist in REL1_23. I think your version is beyond REL1_24?

Kghbln added a comment.Jan 17 2015, 9:45 AM

No, just a little beyond REL1_23 (see the exact version in my original post). However if the code is not there it cannot be fixed. :) I should probably give REL1_23 and not an in-between version a shot and come back here if there are still worries. So no worries for now. Thank you again!

Kghbln awarded a token.Jan 17 2015, 9:45 AM
Kghbln added a comment.Feb 5 2015, 7:44 PM

Just as the long promised follow up. I have just changed to REL1_23 of CommonsMetadata and indeed no PHP notices are emitted. Cool.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits