Page MenuHomePhabricator

AbuseFilter should provide an easy way to un-throttle a rule.
Closed, DuplicatePublic

Description

Right now, if a rule has been throttled a message is displayed:

Warning: This filter was automatically disabled as a safety measure. It reached the limit of matching more than 5.00% of actions.

There is no way to un-throttle the rule in the UI.

Acceptance criteria

  • When a filter has been throttled, there is a link/button available in the UI to re-enable the filter.

Event Timeline

MarkAHershberger raised the priority of this task from to Needs Triage.
MarkAHershberger updated the task description. (Show Details)
MarkAHershberger added a project: AbuseFilter.
Aklapper triaged this task as Lowest priority.Jan 8 2015, 1:09 PM

@MarkAHershberger: So currently, when a filter gets throttled, how do you get it working again? Do you have to edit the filter or something?

Editing the filter, or disabling and re-enabling, will reset the throttle.

Well, do we really want this? If a filter has been throttled, chances are it's doing something wrong. Instead, filter's conditions and/or throttling parameters should be reviewed. A quick button may be useful for instance when testing a filter and you need to trigger a harmful action multiple times, but this isn't a common use case. Instead, I think if a filter gets throttled it really needs a change.

I would love to have this in my testing environment; but then again, in my testing environment I can easily un-throttle a filter by a direct SQL query.

I agree with Daimona that in production, un-throttling should only occur after a careful review of the filter and correcting its logic.

I think a piece of useful information would be to know how often filters get un-throttled. Is that something we can determine from the logs?

Yeah, actually when testing it's enough to change global variables which determine when to throttle the filter. Later I'll investigate to answer your question, but I think this bug should be closed, actually.

EDIT: @Huji, the throttled marker is reset here so yeah, it's possible e.g. to put a wfDebug there. Should we?