Page MenuHomePhabricator

Civi: Default "refund has been completed" checkbox to checked
Closed, ResolvedPublic1 Estimated Story Points

Description

Sometimes, Major Gifts and/or Donor Services will need to manually enter a refund in Civi. There’s a checkbox that can show the refund as “completed” or “pending.” More frequently, it should be marked as completed. Make this the default.

https://gerrit.wikimedia.org/r/#/c/180030/

TBD: submodule bump

Event Timeline

atgo assigned this task to awight.
atgo raised the priority of this task from to Medium.
atgo updated the task description. (Show Details)
atgo subscribed.
atgo edited a custom field.
atgo renamed this task from Default "refund has been completed" checkbox to checked to Civi: Default "refund has been completed" checkbox to checked.Jan 9 2015, 8:12 PM

@CaitVirtue @RLewis could you confirm that this is working as you expect?

@awight and @CaitVirtue I tried to refund a $1.00 contribution that was under my record in Civi and received this error message:

Exception: "A fatal error was triggered: Failed to mark refund: INVALID_MESSAGE Empty gateway transaction id"

#0 /srv/org.wikimedia.civicrm/civicrm/CRM/Contribute/Form/Refund.php(87): CRM_Core_Error::fatal("Failed to mark refund: INVALID_MESSAGE Empty gateway transaction id")
#1 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/Form.php(261): CRM_Contribute_Form_Refund->postProcess()
#2 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/StateMachine.php(159): CRM_Core_Form->mainProcess()
#3 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/QuickForm/Action/Next.php(60): CRM_Core_StateMachine->perform(Object(CRM_Contribute_Form_Refund), "next", "Next")
#4 /srv/org.wikimedia.civicrm/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Next->perform(Object(CRM_Contribute_Form_Refund), "next")
#5 /srv/org.wikimedia.civicrm/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Contribute_Form_Refund), "next")
#6 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/Controller.php(310): HTML_QuickForm_Page->handle("next")
#7 /srv/org.wikimedia.civicrm/civicrm/CRM/Utils/Wrapper.php(116): CRM_Core_Controller->run()
#8 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/Invoke.php(194): CRM_Utils_Wrapper->run("CRM_Contribute_Form_Refund", NULL, NULL)
#9 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/Invoke.php(51): CRM_Core_Invoke::_invoke((Array:3))
#10 /srv/org.wikimedia.civicrm/civicrm/drupal/civicrm.module(500): CRM_Core_Invoke::invoke((Array:3))
#11 [internal function](): civicrm_invoke("contribute", "refund")
#12 /srv/org.wikimedia.civicrm/drupal/includes/menu.inc(517): call_user_func_array("civicrm_invoke", (Array:2))
#13 /srv/org.wikimedia.civicrm/drupal/index.php(21): menu_execute_active_handler()
#14 {main}
Sorry but we are not able to provide this at the moment.
A fatal error was triggered: Failed to mark refund: INVALID_MESSAGE Empty gateway transaction id

Hi Rosie! The donation under your name doesn't look it came in online. It's missing some of the fields we need to do an automatic refund. If you need another to test with, I made a $1 donation via CC last night to test a deployment. It shows up under my email on 2015-01-30.

@Ejegg what are the fields required for an automatic refund?

Thanks @Ejegg that makes sense. I just refunded the donation you made and that seemed to work fine and the completed check box was the default. I have a screenshot of how it shows up in Civi for you to check it looks ok but can't figure out how to add it here.

If it looks fine to you, I'll trust it! The change was very minor, and only to the form setup. I'd be very surprised if it had any other effects.

@RLewis for future information, there's a little icon that looks like a cloud with an arrow in it. That's the one for uploading files (including images).

Thanks! Closing this task.