Page MenuHomePhabricator

First time opening new translation creation dialog, source selector has nothing selected by default
Closed, ResolvedPublic

Description

pasted_file (1,031×656 px, 80 KB)

Event Timeline

Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added a project: ContentTranslation.
Nikerabbit subscribed.

Fixme by @Krinkle on https://gerrit.wikimedia.org/r/#/c/179191/ :

localStorage check is broken. In JavaScript, accessing undeclared variables throws a ReferenceError exception. A boolean cast if-statement is not sufficient.

Either use a typeof check to evaluate the identifier safely, or boolean-cast it as a property of an object (e.g. window, like window.localStorage) which yields the undefined value for undefined properties.

https://www.mediawiki.org/wiki/CC/JS#Type_checks

Change 183830 had a related patch set uploaded (by Amire80):
Check for localStorage availability using window.localStorage

https://gerrit.wikimedia.org/r/183830

Patch-For-Review

Change 183834 had a related patch set uploaded (by Amire80):
Handle unidirectional language pairs in the selector

https://gerrit.wikimedia.org/r/183834

Patch-For-Review

Amire80 triaged this task as Medium priority.Jan 9 2015, 12:14 PM
Amire80 added a project: LE-Sprint-81.
Amire80 set Security to None.
Amire80 moved this task from Backlog to In Review on the LE-Sprint-81 board.

Change 183830 merged by jenkins-bot:
Check for localStorage availability using window.localStorage

https://gerrit.wikimedia.org/r/183830

Change 183834 merged by jenkins-bot:
Handle unidirectional language pairs in the selector

https://gerrit.wikimedia.org/r/183834