Page MenuHomePhabricator

Main menu should be represented as a View incorporated in Skin
Closed, ResolvedPublic

Description

mainmenu.js should be moved into Skin.js
Skin should have a method getMainMenu
which should return an instance of MainMenu

Calls to M.require( 'mainmenu' ) should be replaced with calls to
M.require( 'skin' )
skin.getMainMenu

Event Timeline

Jdlrobson created this task.Jan 8 2015, 9:37 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson added a project: Technical-Debt.
Jdlrobson set Security to None.
Jdlrobson moved this task from Incoming to 2015-16 Q4 on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.

Change 184832 had a related patch set uploaded (by Bmansurov):
WIP: Represent main menu as a View incorporated in Skin

https://gerrit.wikimedia.org/r/184832

Patch-For-Review

Change 184832 merged by jenkins-bot:
Represent main menu as a View incorporated in Skin

https://gerrit.wikimedia.org/r/184832

Jdlrobson closed this task as Resolved.Jan 16 2015, 9:52 PM