Page MenuHomePhabricator
Create Task
Maniphest T86266

Logging should be handled outside of core gateway class
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Create a separate logger class so DonationInterface can log things even when gateways are not fully instantiated. Should handle scrubbing verboten values and work with whichever backend (mediawiki / drupal) DI is used in.

Details

Show related patches Customize query in gerrit

Related Objects

Mentioned In
rEDIVabd7dd6c9ac1: Add Monolog and PSR\Logger
rMEXT61dd21ebf410: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXT1843f60c4a61: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXT84a11b72f529: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXTea062ee0001d: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXTf5439445bb95: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXTdd7a32d2c25e: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXTa62973343381: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXTec73a0ec7d0e: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXT47d25201726b: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rMEXTe627d50c1a03: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface…
rEDOI7158154fbc4c: Use PSR logging in GatewayPage classes
rEDOI66ef9e4f3f2a: Use PSR logging in gateway adapters
rEDOI4085b4e68948: Add Monolog handlers and processors
rEDOI3f29881dc49b: Use PSR logging for gateway extras
rEDOI3e8b0acd77d4: Use PSR logging in DonationData
rEDOI0262ac36e2c6: Revert "Move some logging functions into DonationLogger"
rEDOIf311c6099c6a: Revert "Use DonationLogger in GatewayPage subclasses"
rEDOIdae2ec7771e9: Revert "Add push and pop fns to DonationLoggerContext"
rEDOI36e3ddbae060: Add push and pop fns to DonationLoggerContext
rEDOI6230aaaf8e5f: Use DonationLogger in GatewayPage subclasses

Event Timeline

Ejegg created this task.Jan 8 2015, 11:46 PM
Ejegg raised the priority of this task from to Medium.
Ejegg updated the task description. (Show Details)
Ejegg added a project: Fundraising-Backlog-Old.
Ejegg edited a custom field.
Ejegg subscribed.
Ejegg moved this task from Backlog to DI Refactor on the Fundraising-Backlog-Old board.Feb 5 2015, 12:33 AM
Ejegg added a project: § Fundraising Sprint Devo.
Ejegg set Security to None.
Ejegg edited a custom field.
• atgo moved this task from In Analysis to Dev Ready on the § Fundraising Sprint Devo board.Feb 5 2015, 1:10 AM
awight awarded a token.Feb 5 2015, 6:57 AM
awight subscribed.Feb 5 2015, 7:00 AM

We would do more and better logging if not wasting our energy passing around and managing a Logger instance.

Also: let's use a PSR-3 library instead of home-brewing.

Ejegg moved this task from Dev Ready to In Development on the § Fundraising Sprint Devo board.Feb 5 2015, 9:03 PM
• atgo assigned this task to Ejegg.Feb 11 2015, 8:34 PM
• atgo subscribed.
• atgo added a comment.Feb 12 2015, 12:13 AM

Testing something... will put this back in 2 seconds

• atgo removed a project: § Fundraising Sprint Devo.Feb 12 2015, 12:13 AM
• atgo added a project: § Fundraising Sprint Devo.
gerritbot subscribed.Feb 18 2015, 8:23 PM

Change 190134 had a related patch set uploaded (by Ejegg):
Add push and pop fns to DonationLoggerContext

https://gerrit.wikimedia.org/r/190134

Patch-For-Review

gerritbot added a comment.Feb 18 2015, 8:23 PM

Change 190135 had a related patch set uploaded (by Ejegg):
Use DonationLogger in GatewayPage subclasses

https://gerrit.wikimedia.org/r/190135

Patch-For-Review

gerritbot added a comment.Feb 18 2015, 8:43 PM

Change 190135 merged by jenkins-bot:
Use DonationLogger in GatewayPage subclasses

https://gerrit.wikimedia.org/r/190135

Ejegg mentioned this in rEDOI6230aaaf8e5f: Use DonationLogger in GatewayPage subclasses.Feb 18 2015, 8:44 PM
Ejegg added a project: Fundraising Sprint Enya.Feb 18 2015, 11:42 PM
Ejegg moved this task from In Analysis to In Development on the Fundraising Sprint Enya board.
gerritbot added a comment.Feb 19 2015, 7:13 PM

Change 190134 merged by jenkins-bot:
Add push and pop fns to DonationLoggerContext

https://gerrit.wikimedia.org/r/190134

awight mentioned this in rEDOI36e3ddbae060: Add push and pop fns to DonationLoggerContext.Feb 19 2015, 7:13 PM
gerritbot added a comment.Feb 23 2015, 7:57 PM

Change 192380 had a related patch set uploaded (by Ejegg):
Add Monolog and PSR\Logger

https://gerrit.wikimedia.org/r/192380

Patch-For-Review

gerritbot added a comment.Feb 23 2015, 7:59 PM

Change 192382 had a related patch set uploaded (by Ejegg):
Revert "Add push and pop fns to DonationLoggerContext"

https://gerrit.wikimedia.org/r/192382

Patch-For-Review

gerritbot added a comment.Feb 23 2015, 7:59 PM

Change 192383 had a related patch set uploaded (by Ejegg):
Revert "Use DonationLogger in GatewayPage subclasses"

https://gerrit.wikimedia.org/r/192383

Patch-For-Review

gerritbot added a comment.Feb 23 2015, 7:59 PM

Change 192384 had a related patch set uploaded (by Ejegg):
Revert "Move some logging functions into DonationLogger"

https://gerrit.wikimedia.org/r/192384

Patch-For-Review

gerritbot added a comment.Feb 23 2015, 8:09 PM

Change 192382 merged by jenkins-bot:
Revert "Add push and pop fns to DonationLoggerContext"

https://gerrit.wikimedia.org/r/192382

gerritbot added a comment.Feb 23 2015, 8:09 PM

Change 192383 merged by jenkins-bot:
Revert "Use DonationLogger in GatewayPage subclasses"

https://gerrit.wikimedia.org/r/192383

gerritbot added a comment.Feb 23 2015, 8:10 PM

Change 192384 merged by jenkins-bot:
Revert "Move some logging functions into DonationLogger"

https://gerrit.wikimedia.org/r/192384

awight mentioned this in rEDOIf311c6099c6a: Revert "Use DonationLogger in GatewayPage subclasses".Feb 23 2015, 8:12 PM
awight mentioned this in rEDOIdae2ec7771e9: Revert "Add push and pop fns to DonationLoggerContext".
awight mentioned this in rEDOI0262ac36e2c6: Revert "Move some logging functions into DonationLogger".
gerritbot added a comment.Feb 23 2015, 8:48 PM

Change 192393 had a related patch set uploaded (by Ejegg):
Use PSR logging in DonationData

https://gerrit.wikimedia.org/r/192393

Patch-For-Review

gerritbot added a comment.Feb 24 2015, 12:11 AM

Change 192385 had a related patch set uploaded (by Ejegg):
Add Monolog handlers and processors

https://gerrit.wikimedia.org/r/192385

Patch-For-Review

gerritbot added a comment.Feb 26 2015, 10:00 PM

Change 192977 had a related patch set uploaded (by Ejegg):
Use PSR logging for gateway extras

https://gerrit.wikimedia.org/r/192977

gerritbot added a project: Patch-For-Review.Feb 26 2015, 10:00 PM

Change 193272 had a related patch set uploaded (by Ejegg):
Use PSR logging in gateway adapters

https://gerrit.wikimedia.org/r/193272

gerritbot added a comment.Feb 26 2015, 10:56 PM

Change 193280 had a related patch set uploaded (by Ejegg):
Use PSR logging in GatewayPage classes

https://gerrit.wikimedia.org/r/193280

Ejegg moved this task from In Development to Pending Code Review on the Fundraising Sprint Enya board.Mar 3 2015, 9:06 PM
awight added a project: Fundraising Sprint Flaming Lips.Mar 5 2015, 4:14 PM
gerritbot added a comment.Mar 5 2015, 4:24 PM

Change 192380 merged by Awight:
Add Monolog and PSR\Logger

https://gerrit.wikimedia.org/r/192380

Ejegg moved this task from In Analysis to Doing on the Fundraising Sprint Flaming Lips board.Mar 5 2015, 5:57 PM
awight moved this task from Doing to Pending Deployment on the Fundraising Sprint Flaming Lips board.Mar 5 2015, 11:15 PM
gerritbot added a comment.Mar 5 2015, 11:33 PM

Change 192385 merged by jenkins-bot:
Add Monolog handlers and processors

https://gerrit.wikimedia.org/r/192385

gerritbot added a comment.Mar 5 2015, 11:33 PM

Change 192393 merged by jenkins-bot:
Use PSR logging in DonationData

https://gerrit.wikimedia.org/r/192393

gerritbot added a comment.Mar 5 2015, 11:33 PM

Change 192977 merged by jenkins-bot:
Use PSR logging for gateway extras

https://gerrit.wikimedia.org/r/192977

Ejegg mentioned this in rEDOI4085b4e68948: Add Monolog handlers and processors.Mar 5 2015, 11:33 PM
Ejegg mentioned this in rEDOI3e8b0acd77d4: Use PSR logging in DonationData.
Ejegg mentioned this in rEDOI3f29881dc49b: Use PSR logging for gateway extras.
gerritbot added a comment.Mar 9 2015, 6:01 PM

Change 193272 merged by jenkins-bot:
Use PSR logging in gateway adapters

https://gerrit.wikimedia.org/r/193272

Ejegg mentioned this in rEDOI66ef9e4f3f2a: Use PSR logging in gateway adapters.Mar 9 2015, 6:01 PM
gerritbot added a comment.Mar 9 2015, 6:09 PM

Change 193280 merged by jenkins-bot:
Use PSR logging in GatewayPage classes

https://gerrit.wikimedia.org/r/193280

awight mentioned this in rEDOI7158154fbc4c: Use PSR logging in GatewayPage classes.Mar 9 2015, 6:09 PM
Ejegg mentioned this in rMEXTe627d50c1a03: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Mar 11 2015, 6:27 AM
Ejegg mentioned this in rMEXT47d25201726b: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
Ejegg mentioned this in rMEXTec73a0ec7d0e: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
Ejegg mentioned this in rMEXTdd7a32d2c25e: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
Ejegg mentioned this in rMEXTa62973343381: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
Diffusion mentioned this in rMEXT84a11b72f529: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Mar 11 2015, 6:28 AM
Diffusion mentioned this in rMEXTf5439445bb95: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
Diffusion mentioned this in rMEXTea062ee0001d: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
Diffusion mentioned this in rMEXT1843f60c4a61: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
Ejegg mentioned this in rMEXT61dd21ebf410: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Mar 11 2015, 6:28 AM
• atgo moved this task from Pending Deployment to Done on the Fundraising Sprint Flaming Lips board.Mar 12 2015, 8:11 PM
awight closed this task as Resolved.Mar 12 2015, 9:31 PM
Ejegg mentioned this in rEDIVabd7dd6c9ac1: Add Monolog and PSR\Logger.Apr 8 2015, 6:17 PM
• atgo added a project: Fundraising-Backlog.Jun 30 2015, 10:16 PM
• atgo moved this task from Triage to Closed Sprint Work Q3 1415 on the Fundraising-Backlog board.Jun 30 2015, 10:18 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:52 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2014/15; removed Fundraising-Backlog.Jan 11 2018, 9:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL