Page MenuHomePhabricator

Improve back button behavior after TOC jump to or when scrolling down (ToC v2)
Open, LowPublic

Description

To reproduce:

  1. Go to a board with the TOC.
  2. Click the 25th item
  3. Go to another page (e.g. by clicking topic history)
  4. Use the browser back button.

It will not take you back the topics you were previously looking at. @Quiddity reported infinite scroll was broken at that point, but @EBernhardson and I haven't been able to reproduce that.

This should be implemented by updating the url in the browser with replaceState while the user is scrolling. If a user comes back to the page the url should be read and the active topic should be jumped to.

See also T94623: Newly posted messages do not show when browser back button is used on Flow Board.

Event Timeline

Mattflaschen-WMF raised the priority of this task from to Needs Triage.
Mattflaschen-WMF updated the task description. (Show Details)
Mattflaschen-WMF renamed this task from Improve back button before after TOC jump to to Improve back button behavior after TOC jump to.Jan 9 2015, 12:11 AM
Mattflaschen-WMF set Security to None.
DannyH renamed this task from Improve back button behavior after TOC jump to to Improve back button behavior after TOC jump to (ToC v2).Jan 9 2015, 12:45 AM
DannyH triaged this task as Normal priority.Jan 9 2015, 12:47 AM
DannyH moved this task from Untriaged to Team discussion on the Collaboration-Team-Triage board.
DannyH added a subscriber: DannyH.Jan 9 2015, 8:09 PM

In story grooming meeting Jan 9th, we decided that this was an edge case we weren't going to tackle yet. We're still working on the model that a Flow board is a "container", not a static page, so trying to mimic the experience of a static page might lock us into behavior that we don't want to build. We'll talk more about this.

I agree we don't want to mimic a static page.

Losing your place when navigating away from infinite scroll/dynamic pages is a well-known issue, and it probably does introduce some friction in Flow as well. However, we don't know how serious an issue it is, nor the implementation cost, which is part of why we decided to defer it.

Mattflaschen-WMF renamed this task from Improve back button behavior after TOC jump to (ToC v2) to Improve back button behavior after TOC jump to or when scrolling down (ToC v2).Jan 16 2015, 6:38 PM
Mattflaschen-WMF added a subscriber: EBernhardson.
Mattflaschen-WMF lowered the priority of this task from Normal to Low.Jan 16 2015, 6:42 PM

For clarity, the item merged in was asking for address bar but not back button (history) adjustment whilst scrolling on the same page.

EBernhardson updated the task description. (Show Details)Jan 17 2015, 1:07 AM

updated description with implementation details, to clarify that the idea is to handle the back button and updating the address bar as a single feature.

Legoktm reopened this task as Open.Dec 1 2017, 6:37 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 6:45 PM
SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 5:53 PM