Page MenuHomePhabricator

Cancel button should be visible when MediaViewer is loading
Open, LowPublic

Description

When MediaViewer starts loading, it displays a black overlay. In rare situations, loading might take long; bugs might even cause it to hang. There should be a way for users to cancel in those cases.


See also: T86288

Event Timeline

Tgr created this task.Jan 9 2015, 3:24 AM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added projects: MediaViewer, Multimedia.
Tgr added a subscriber: Tgr.
Tgr updated the task description. (Show Details)
Tgr set Security to None.
Fomafix added a subscriber: Fomafix.Jan 9 2015, 1:03 PM
Krinkle renamed this task from MediaViewer should have a cancel button while loading to Cancel button should be visible when lightbox image is loading.Aug 25 2015, 4:35 AM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 25 2015, 4:35 AM
Tgr renamed this task from Cancel button should be visible when lightbox image is loading to Cancel button should be visible when MediaViewer is loading.Aug 25 2015, 7:25 AM
Tgr added a comment.Aug 25 2015, 7:29 AM

There is a cancel button while the image is loading (or if there isn't one, that's a regression) but not while MediaViewer itself (the ResourceLoader module) is loading. There is a small head-loaded module (mmv.head) which sets click handlers and sets up a black overlay on click and loads the full script, which is the one that sets up the cancel button and the rest of the UI. Not sure how much sense that setup makes now with RL being fully async (and a lot faster than it used to be).

Fomafix added a comment.EditedAug 25 2015, 8:16 AM

Maybe the solution is to preload the module with the progress bar and the cancel button already on page load and not only on clicking an image.

Jdforrester-WMF triaged this task as Low priority.Sep 4 2015, 6:56 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 7:03 PM

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

simon04 moved this task from Backlog to Design on the MediaViewer board.Jun 10 2019, 7:09 AM
Tgr removed a subscriber: Tgr.Jul 9 2019, 6:03 PM