$ php ../../maintenance/convertExtensionToRegistration.php VisualEditor.php
Fatal error: Invalid operand type was used: cannot perform this operation with arrays in /vagrant/mediawiki/extensions/VisualEditor/VisualEditor.php on line 1446
(Tested against VisualEditor rEVED560cd3edf7675069ee92fe8a31373a7ce74392ae.)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Handle more cases in convertExtensionToRegistration.php | mediawiki/core | master | +32 -7 |
The general issue here is that we're not setting defaults for the globals, so constructs like $wgResourceModules += array( ... ) will fail since $wgResourceModules doesn't exist in the function scope. A quick hack around this is to add: $wgResourceModules = array() right to the line before while running the conversion script. VE also does an array_merge with $wgContentNamespaces, which has the same issue.
My quick grep shows that there are enough extensions doing something like this so it makes sense to fix it in the script.
Change 184208 had a related patch set uploaded (by Legoktm):
Handle more cases in convertExtensionToRegistration.php
Above patch fixes nearly everything. I'm not sure how to interpret $wgVisualEditorNamespaces = array_merge( $wgContentNamespaces, array( NS_USER ) ); though.
Is that supposed to represent the content namespaces that have been customized by individual wikis? Or the value from DefaultSettings.php?
The value that's been customised; we achieve it by loading VE late. As you said, we should do this in a better way.
Change 184208 merged by jenkins-bot:
Handle more cases in convertExtensionToRegistration.php