Maniphest T86399

Wordbreak detection is faulty for selection starting just up-page of a link annotation
Closed, ResolvedPublic40 Estimated Story Points
Actions

Description

In the string:

Alice bought Charlie deep emerald fish

… where "deep emerald" is a link, if the cursor is inside the link:

Alice bought Charlie d|eep emerald fish

… and you press the link button, the whole link ("deep emerald") is selected; however, if the cursor is just up-page of the link:

Alice bought Charlie |deep emerald fish

… then only the first word ("deep") is selected, causing nasty breakages and no-wiki'ing galore. Happens in standalone too.

Details

	Project	Branch	Lines +/-	Subject
	VisualEditor/VisualEditor	master	+21 -2	Expand annotation beyond a word if it exists

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Mooeypoo	T72286 VisualEditor: Adding a link right before a wikilinked word leads to unexpected results, including a nowiki
		Resolved		Mooeypoo	T86399 Wordbreak detection is faulty for selection starting just up-page of a link annotation

Event Timeline

Possibly related to T78202: Wordbreak detection is faulty for selection starting just down-page of a single character?

Jdforrester-WMF mentioned this in T72286: VisualEditor: Adding a link right before a wikilinked word leads to unexpected results, including a nowiki.Jan 10 2015, 3:40 AM

Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.

Krenair added a subscriber: Krenair.Jan 10 2015, 3:47 AM

Jdforrester-WMF assigned this task to dchan.Jan 15 2015, 1:24 AM

Jdforrester-WMF set Security to None.

Jdforrester-WMF moved this task from External and Administrivia to Blocked on the VisualEditor board.

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM

Jdforrester-WMF edited a custom field.Jan 23 2015, 11:55 PM

Jdforrester-WMF edited a custom field.Feb 2 2015, 7:49 PM

Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:04 PM

• TrevorParscal edited a custom field.Feb 4 2015, 7:13 PM

Change 197425 had a related patch set uploaded (by Mooeypoo):
Expand annotation beyond a word if it exists

https://gerrit.wikimedia.org/r/197425

gerritbot added a project: Patch-For-Review.Mar 17 2015, 10:21 PM

Mooeypoo claimed this task.Mar 17 2015, 10:52 PM

Mooeypoo added a subscriber: dchan.

Jdforrester-WMF closed this task as Resolved.Mar 18 2015, 12:12 AM

Jdforrester-WMF edited projects, added WMF-deploy-2015-03-18_(1.25wmf22); removed Patch-For-Review.

Change 197425 merged by jenkins-bot:
Expand annotation beyond a word if it exists

https://gerrit.wikimedia.org/r/197425

Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 18 2015, 12:22 AM

Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Mar 18 2015, 2:29 AM

Mooeypoo mentioned this in rGVEDd58e84161d2b: Expand annotation beyond a word if it exists.Mar 23 2015, 3:53 PM

Ryasmeen added a subscriber: Ryasmeen.Mar 26 2015, 9:43 PM

This comment was removed by Ryasmeen.

Ryasmeen added a project: Verified-in-Phase0.Mar 26 2015, 9:45 PM

Ryasmeen added a project: Verified-in-Phase2.