Support @weekly et al in crontab
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	valhallasw
	Jan 10 2015, 3:44 PM

Description

The script that parses the crontab to check for jsub invocations breaks when @weekly is used instead of 0 0 * * 0, presumably because it parses by splitting on space.

For example,

@weekly /usr/bin/jsub -N taxonomy -mem 512m -once /data/project/wikibugs/py-wikibugs2/bin/python /data/project/wikibugs/wikibugs2/taxonomy.py > /dev/null

gets mangled into

/usr/bin/jsub -N taxonomy -mem 512m /usr/bin/jsub -N cron-tools.wikibugs-1 -once -quiet -once /data/project/wikibugs/py-wikibugs2/bin/python /data/project/wikibugs/wikibugs2/taxonomy.py > /dev/null

Related Objects

Mentioned In: T156174: Rewrite /usr/local/bin/crontab in python; fix bugs
Mentioned Here: rOPUPca4568eab87f: Tool Labs: Make xcrontab support @syntax

Event Timeline

valhallasw created this task.Jan 10 2015, 3:44 PM

valhallasw raised the priority of this task from to Needs Triage.

valhallasw updated the task description. (Show Details)

valhallasw added a project: Toolforge.

valhallasw added subscribers: Aklapper, valhallasw.

scfc triaged this task as Lowest priority.Apr 6 2015, 8:05 AM

scfc subscribed.

scfc moved this task from Backlog to Ready to be worked on on the Toolforge board.Apr 6 2015, 10:35 AM

Aklapper added a project: Cloud-Services.Oct 24 2015, 8:02 PM

zhuyifei1999 mentioned this in T156174: Rewrite /usr/local/bin/crontab in python; fix bugs.Feb 8 2017, 6:14 PM

This was supposed to be fixed in ca4568e.

WFM:

tools.scfc-test-can-be-deleted-anytime@tools-bastion-03:~$ echo '@weekly true' | crontab && crontab -l

NOTE: some crontab entries have been modified to grid submissions.
      You may want to examine the result with 'crontab -e'.

@weekly  /usr/bin/jsub -N cron-tools.scfc-test-can-be-deleted-anytime-1 -once -quiet true 
tools.scfc-test-can-be-deleted-anytime@tools-bastion-03:~$

For reference, the regex may not be good enough and this could be still an issue. See https://gerrit.wikimedia.org/r/#/c/336998/9/misctools/oge-crontab

Support @weekly et al in crontabClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Support @weekly et al in crontab
Closed, ResolvedPublic
Actions