Page MenuHomePhabricator

FlaggedRevs should not use obsolete HTML attributes (use CSS instead)
Open, LowPublic

Description

FlaggablePageView.php should use CSS instead of obsolete HTML attributes such as "align", "border", "width", "cellpadding" and "cellspacing".

Event Timeline

He7d3r created this task.Jan 12 2015, 8:38 PM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added a project: good first task.
He7d3r added a subscriber: He7d3r.
Aklapper triaged this task as Low priority.Jan 12 2015, 8:44 PM

[Please add a code project; setting MediaWiki-extensions-FlaggedRevs here]

IoannisKydonis added a subscriber: IoannisKydonis.

I will fix this.

Change 266047 had a related patch set uploaded (by IoannisKydonis):
Replace obsolete HTML attributes with CSS.

https://gerrit.wikimedia.org/r/266047

Zache added a subscriber: Zache.May 8 2017, 6:32 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 8 2017, 6:32 AM
Framawiki moved this task from Backlog to Doing on the good first task board.Dec 2 2017, 1:43 PM

Change 266047 abandoned by Thiemo Kreuz (WMDE):
[mediawiki/extensions/FlaggedRevs@master] Replace obsolete HTML attributes with CSS.

Reason:
Sorry, but all this patch does is replacing one style with another one, without actually improving the situation. The issue is not really which syntax is used. The old one works just fine. Browsers will never stop supporting it. The issue is that this stuff is hard-coded in the middle of the HTML.

https://gerrit.wikimedia.org/r/266047

IoannisKydonis removed IoannisKydonis as the assignee of this task.Mon, Nov 23, 1:31 PM