From @Cmcmahon in IRC:
For a Flow topic, Hide/Delete/Suppress all require reasons, but Lock does not. Strikes me as strange (and it's making the tests fail sometimes, I'll be fixing that)
Description
Description
Related Objects
Related Objects
- Mentioned In
- T86880: Previewing of lock message is broken ("content parameter must be set")
T86879: Both lock message and summary (if any) should display when entering/previewing a lock action
T86877: Unlock form should be a modal - Mentioned Here
- T86877: Unlock form should be a modal
T86880: Previewing of lock message is broken ("content parameter must be set")
T86879: Both lock message and summary (if any) should display when entering/previewing a lock action
T86377: No placeholder text in Flow lock topic textarea
Event Timeline
Comment Actions
Topic Lock does require a reason, but it's not presented in a modal. It's presented inline in the titlebar because that's where Flow will forever display the reason to lock that you give. So it's more like summarize, and it's not like the other moderation reasons which only appear in the topic history.
However, there are a bunch of glitches with this.
- When you unlock a topic the form where you give your reason to unlock is also displayed inline in the titlebar. That doesn't make sense, because the reason to lock and your reason to unlock will both go away.
- A topic can have a summary and a lock reason, but while you're entering the lock reason the summary is hidden for no reason.
- Fixing T86377: No placeholder text in Flow lock topic textarea would help a bit.
- When you lock a topic and click [Preview] you get a red errorbox containing "The content parameter must be set" because the API call to flow-parsoid-utils to convert from:wikitext to:html isn't provided the content to convert.
- I don't think the lock reason is wikitext! It's not like summarize.
Comment Actions
This seems logical, so I think this bug should be closed.
However, there are a bunch of glitches with this.
Nice digging. :)
- When you unlock a topic the form where you give your reason to unlock is also displayed inline in the titlebar. That doesn't make sense, because the reason to lock and your reason to unlock will both go away.
Filed as T86877: Unlock form should be a modal.
- A topic can have a summary and a lock reason, but while you're entering the lock reason the summary is hidden for no reason.
Filed as T86879: Both lock message and summary (if any) should display when entering/previewing a lock action
- When you lock a topic and click [Preview] you get a red errorbox containing "The content parameter must be set" because the API call to flow-parsoid-utils to convert from:wikitext to:html isn't provided the content to convert.
- I don't think the lock reason is wikitext! It's not like summarize.
Filed as T86880: Previewing of lock message is broken ("content parameter must be set") (though quite possibly we will want to allow wikitext here at some point).