Page MenuHomePhabricator

Migrate Gerrit project ownership request system (+2 rights) to Phabricator
Closed, ResolvedPublic

Description

Developer-notice: Now requests for Gerrit repository ownership are handled at Repository-Ownership-Requests in Phabricator, instead of on-wiki at mediawiki.org.


Previous description:

Currently, requests for +2 rights in Gerrit repositories are managed via a wiki page on MediaWiki.org: https://www.mediawiki.org/wiki/Gerrit/Project_ownership

This clearly hasn't been a very successful process, with most requests languishing for months.

Now that we have a nice issue tracker (not just a bug tracker), it is suggested to migrate the +2 rights request process here to Phabricator. Each person requesting +2 rights (or nominating someone else for rights) would create a task here in a dedicated project. The old wiki-based process would be closed down.

Hopefully this would attract greater visibility to the +2 request procedure (rather than forcing people to check their MW.org watchlist every few weeks).

Event Timeline

TTO created this task.Jan 13 2015, 11:37 AM
TTO raised the priority of this task from to Needs Triage.
TTO updated the task description. (Show Details)
TTO added projects: Gerrit, Phabricator.
TTO added subscribers: TTO, Qgil, demon and 2 others.
Qgil awarded a token.Jan 13 2015, 11:51 AM
TTO added a comment.Jan 13 2015, 11:58 AM

Not a dupe; that task is about requesting new Gerrit repositories; this one is about +2 rights. But the two tasks are similar in scope. T38269 is also asking for a wiki-page based process to be moved to somewhere more suitable.

Qgil added a comment.EditedJan 13 2015, 12:19 PM

Can we just reuse #Wikimedia-Git-or-Gerrit for this process, asking people to file the same information that is now requested in the wiki page?

Aklapper renamed this task from Migrate Gerrit project ownership request system to Phabricator to Migrate Gerrit project ownership request system (+2 rights) to Phabricator.Jan 13 2015, 2:45 PM
Aklapper set Security to None.
chasemp triaged this task as Normal priority.Jan 13 2015, 7:38 PM
Qgil moved this task from To Triage to Need discussion on the Phabricator board.
Qgil claimed this task.Feb 2 2015, 7:13 AM
Qgil added a project: ECT-February-2015.
Nemo_bis added a comment.EditedFeb 2 2015, 7:16 AM
In T86639#973256, @Qgil wrote:

Can we just reuse #Wikimedia-Git-or-Gerrit for this process, asking people to file the same information that i now requested in the wiki page?

Then the project would need an exception for people to know that !vote is not disallowed as it usually is on the issue tracker.

Qgil added a comment.Feb 2 2015, 10:34 AM

Yes, in the new instructions we can encourage people to use thumbs up/down tokens in addition to whatever comments they want to leave.

Nemo_bis removed a subscriber: Nemo_bis.Feb 2 2015, 1:57 PM
Tgr added a subscriber: Tgr.Feb 2 2015, 9:27 PM
Qgil added a subscriber: QChris.Feb 3 2015, 8:46 AM

Something unclear to me is who can process requests. Is there a list somewhere?

https://www.mediawiki.org/wiki/Gerrit/Project_ownership says

Anyone in that group can now add more owners via https://gerrit.wikimedia.org/r/#/admin/projects/

but apparently this is not true, and the owners of a repo don't have permissions to add new owners on that repo. In practice I ping to @chad and @QChris whenever someone asks me, but this is clearly not scalable.

demon added a comment.Feb 3 2015, 2:50 PM

Anyone in Projects and group creators (which includes all admins and ops) has the ability to do this.

This power was devolved some time ago, but people don't make use of it.

Qgil moved this task from Backlog to Doing on the ECT-February-2015 board.Feb 3 2015, 7:52 PM
Qgil added a subscriber: hashar.

Note Gerrit Administrators are allowed to create repositories as well https://gerrit.wikimedia.org/r/#/admin/groups/1,members
I never ever honored any request on the wiki page https://www.mediawiki.org/wiki/Gerrit/Project_ownership#Requests , merely because I hate wikitext based workflow. I have created a few that were requested either personally over IRC or via Bugzilla.
A mistake we did when creating Gerrit was lack of peer reviewed process to create repositories and changes user rights. We end up with a few people having the responsibility and no real way of track what is being changed nor wether the resulting configuration is consistent.
I would love to see repo creations and rights to be tracked via peer review / git as configuration changes. Then you only need a couple of folks with the actual rights to +2 (and thus merge).

Interesting. Do you prefer to implement this peer review / git process right away, should we use the Phabricator based process proposed here as an interim solution, or should we keep the current process at mediawiki.org until, say, we have Gerrit-Migration in Phabricator?

I would dish out the mediawiki.org page and move to Phabricator. Much like ops have an ops access request queue. Then have a community of people having appropriate Gerrit user rights made watchers of the projects and handle the queue.

Ideally, we would get the project creation and user rights config managed via a git repo, this way we could leverage the Gerrit code review system to have a peer review / workflow to approve creation of repositories. That needs a lot of integration works though we can steal part from OpenStack which using a git repo to configure Gerrit projects. I don't think it is worth it.

TL;DR: migrate to a Phabricator project with assigned people.

Sumana used to check the wiki page regularly, so requests would be processed on a timely basis. Whenever I've asked Chad on IRC to take a look at the page, he'd usually resolve them pretty quickly.

I typically prefer on-wiki workflows, but if moving to Phabricator gets it more visibility, I'm all for it.

Qgil added a comment.Feb 11 2015, 11:24 AM

If someone is watching regularly, then probably on-wiki and on-task are probably very similar. However, if this is not the case, then Phabricator offers better tools to CC, prioritize and, basically, annoy the people that can solve your problem. :)

So if I interpret comments on T88443 correctly, it is wanted to move this to a Phabricator project that people would join the project. Then folks (who?) would join by becoming project members and subscribe to the project in order to receive updates?

Qgil raised the priority of this task from Normal to High.Feb 23 2015, 6:51 PM

I plan to complete this task this week.

So if I interpret comments on T88443 correctly, it is wanted to move this to a Phabricator project that people would join the project. Then folks (who?) would join by becoming project members and subscribe to the project in order to receive updates?

Oh no! The aim of this task is to phase out the wiki page https://www.mediawiki.org/wiki/Gerrit/Project_ownership and have requesters fill tasks in Phabricator. T88443 is about creating a group of people that will receive notifications / act on those requests.

@hashar: Yeah that's also how I understood. I just expressed it badly, sorry for that!

I missed the implementation part...I can't join the approvers group, so how do I watch all requests like I was able to do on a wiki page?

@Legoktm: Any member of the group can add you to the group: https://phabricator.wikimedia.org/project/members/1076/

That doesn't make sense, because I can't actually give people ownership permissions. I just want to be able to watch all ownership requests.

Qgil added a comment.Feb 24 2015, 4:43 PM

Maybe in this case we can just loosen the policy to join the Phabricator project, since the actual permissions are given in Gerrit.

Qgil added a comment.Feb 24 2015, 9:27 PM

@Legoktm, @Jdforrester-WMF, now the projects is joinable by all users.

@Legoktm, @Jdforrester-WMF, now the projects is joinable by all users.

Thanks!

Qgil updated the task description. (Show Details)Mar 3 2015, 1:45 PM
Qgil added a project: Developer-notice.
gpaumier moved this task from Announce on wikitech-l to Archive on the Developer-notice board.
gpaumier moved this task from Archive to Recently announced on the Developer-notice board.
Restricted Application added a subscriber: scfc. · View Herald TranscriptSep 24 2015, 11:35 PM