Maniphest T86686

Ressurect phpunit tests for the CRM modules
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

These tests have gotten stale due to disuse. Make them all pass, or skip failing tests for now.

Also: update documentation for how to install and use this repo, and add documentation on how to run the tests.

Details

	Subject	Repo	Branch	Lines +/-
	Delete bad references	wikimedia/fundraising/crm/civicrm	master	+2 -2
	obsessive safety checks	wikimedia/fundraising/crm	master	+4 -2
	Reinstate some missing schema upgrades	wikimedia/fundraising/crm	master	+3 -0
	Fix unit tests	wikimedia/fundraising/crm	master	+8 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ejegg	T89404 Create unit and integration tests for Fundraising extensions to identify breaking MediaWiki changes
		Resolved		awight	T78100 Continuous integration - CiviCRM
		Declined		None	T90630 Recurring Payments Reporting
		Resolved		• mepps	T97372 Enable ability to look up contacts by phone number
		Resolved		None	T77910 [epic] Upgrade Civi to 4.6 & integrate new reporting
		Resolved		awight	T86103 CI for Civi: provision and run tests under Jenkins/Zuul
		Resolved		awight	T86686 Ressurect phpunit tests for the CRM modules
		Declined		None	T88379 Skip tests when modules not enabled

Event Timeline

awight created this task.Jan 13 2015, 7:00 PM

awight raised the priority of this task from to Medium.

awight updated the task description. (Show Details)

awight added a project: § Fundraising Sprint Abba.

awight subscribed.

awight moved this task from In Analysis to Dev Ready on the § Fundraising Sprint Abba board.Jan 13 2015, 7:30 PM

awight moved this task from Dev Ready to In Development on the § Fundraising Sprint Abba board.

awight updated the task description. (Show Details)

awight set Security to None.

awight edited a custom field.

A minor thing I noticed is that my local db still has no default value for drupal.contribution_tracking.anonymous and optout. The production box has "default null" for these columns. This should have been fixed by a schema upgrade, I assume other dev instances will have this issue.

Change 184720 had a related patch set uploaded (by Awight):
Fix unit tests

https://gerrit.wikimedia.org/r/184720

Patch-For-Review

awight moved this task from In Development to Pending Code Review on the § Fundraising Sprint Abba board.Jan 13 2015, 7:48 PM

awight edited a custom field.

awight added projects: Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM.Jan 13 2015, 11:41 PM

• atgo assigned this task to awight.Jan 14 2015, 10:58 PM

• atgo added a project: § Fundraising Sprint Beastie Boys.Jan 15 2015, 12:13 AM

• atgo moved this task from In Analysis to Pending Code Review on the § Fundraising Sprint Beastie Boys board.

Change 184720 merged by Katie Horn:
Fix unit tests

https://gerrit.wikimedia.org/r/184720

awight moved this task from Pending Code Review to In Development on the § Fundraising Sprint Beastie Boys board.Jan 15 2015, 3:02 AM

Ejegg moved this task from In Development to Done on the § Fundraising Sprint Beastie Boys board.Jan 15 2015, 6:08 PM

awight moved this task from Done to In Development on the § Fundraising Sprint Beastie Boys board.Jan 15 2015, 6:32 PM

awight edited a custom field.

Change 185206 had a related patch set uploaded (by Awight):
Delete bad references

https://gerrit.wikimedia.org/r/185206

Patch-For-Review

Change 185337 had a related patch set uploaded (by Awight):
Reinstate some missing schema upgrades

https://gerrit.wikimedia.org/r/185337

Patch-For-Review

Change 185338 had a related patch set uploaded (by Awight):
obsessive safety checks

https://gerrit.wikimedia.org/r/185338

Patch-For-Review

awight moved this task from In Development to Pending Code Review on the § Fundraising Sprint Beastie Boys board.Jan 15 2015, 11:34 PM

Change 185337 merged by Ejegg:
Reinstate some missing schema upgrades

https://gerrit.wikimedia.org/r/185337

Change 185338 merged by Ejegg:
obsessive safety checks

https://gerrit.wikimedia.org/r/185338

@awight please check out status on this

• atgo added a project: § Fundraising Sprint the Cure.Jan 28 2015, 11:40 PM

• atgo moved this task from In Analysis to Pending Code Review on the § Fundraising Sprint the Cure board.

Just this easy one left to review:
https://gerrit.wikimedia.org/r/#/c/185206/

rad! let's kick it out :)

once Jenkins decides to play nice

• atgo moved this task from Backlog to UserRequests (misc) on the Wikimedia-Fundraising-CiviCRM board.Jan 29 2015, 9:22 PM

awight moved this task from Pending Code Review to In Development on the § Fundraising Sprint the Cure board.Jan 30 2015, 12:47 AM

awight added a project: § Fundraising Sprint Devo.Feb 5 2015, 7:32 AM

Status: There is a tiny thing I should continue fixing in https://gerrit.wikimedia.org/r/#/c/185206/

awight moved this task from In Analysis to In Development on the § Fundraising Sprint Devo board.Feb 5 2015, 7:36 AM

awight added a parent task: T86103: CI for Civi: provision and run tests under Jenkins/Zuul.Feb 5 2015, 7:42 AM

awight renamed this task from Make CiviCRM phpunit tests healthy again to Ressurect phpunit tests for the CRM modules.Feb 5 2015, 7:54 AM

awight raised the priority of this task from Medium to High.

awight added a subtask: T88379: Skip tests when modules not enabled.

• atgo edited projects, added Fundraising Sprint Enya; removed § Fundraising Sprint Devo.Feb 11 2015, 11:17 PM

@awight is this a blocker for upgrading to 4.4?

awight closed this task as Resolved.Feb 19 2015, 5:55 PM

awight moved this task from Dev Ready to Pending Deployment on the Fundraising Sprint Enya board.

awight moved this task from Pending Deployment to Done on the Fundraising Sprint Enya board.

K4-713 mentioned this in rWFCH928812fd5193: Delete bad references.Mar 3 2015, 8:56 PM

awight mentioned this in rWFCGf273d9132cb1: Fix unit tests.Mar 3 2015, 9:08 PM

awight mentioned this in rWFCG80cfed8bb672: Reinstate some missing schema upgrades.

Ejegg mentioned this in rWFCGb25c1e557b49: obsessive safety checks.Mar 3 2015, 9:08 PM

• atgo added a project: Fundraising-Backlog.Jun 30 2015, 10:16 PM

• atgo moved this task from Triage to Closed Sprint Work Q3 1415 on the Fundraising-Backlog board.Jun 30 2015, 10:18 PM

• mmodell removed a subscriber: awight.Jun 22 2017, 9:52 PM

• DStrine edited projects, added Fr-tech-archived-from-FY-2014/15; removed Fundraising-Backlog.Jan 11 2018, 9:29 PM

Ejegg closed subtask T88379: Skip tests when modules not enabled as Declined.Sep 21 2021, 12:24 AM