Page MenuHomePhabricator
Create Task
Maniphest T86809

testImportDoesntCompletelyFail Flow test failing on Thanks changes
Closed, ResolvedPublic
Actions

Description

Thanks continuous integration PHPUnit tests are failing because of a Flow test, Flow\Tests\Import\TalkpageImportOperationTest::testImportDoesntCompletelyFail . See https://gerrit.wikimedia.org/r/#/c/184083/ .

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Flowwmf/1.26wmf10+18 -0Fix TalkpageImportOperationTest
mediawiki/extensions/Flowmaster+18 -0Fix TalkpageImportOperationTest
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Jan 14 2015, 7:47 PM
• Mattflaschen-WMF raised the priority of this task from to High.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added projects: Collaboration-Team-Triage, StructuredDiscussions.
• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2015, 7:47 PM
Catrope added a subscriber: Catrope.Jun 16 2015, 7:18 PM

This seems to be intermittent. I was able to merge https://gerrit.wikimedia.org/r/218681 just fine, but https://gerrit.wikimedia.org/r/#/c/218683/1 failed due to this bug.

18:51:39 There was 1 error:
18:51:39 
18:51:39 1) Flow\Tests\Import\TalkpageImportOperationTest::testImportDoesntCompletelyFail
18:51:39 Flow\Exception\PermissionException: Formatting for wrong user: 127.0.0.1 instead of UTSysop
18:51:39 
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/Block/Block.php:152
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/Block/Header.php:58
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/View.php:56
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/Content/BoardContent.php:192
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/includes/page/WikiPage.php:2115
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/includes/page/WikiPage.php:1756
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/TalkpageManager.php:159
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/Import/Importer.php:544
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/tests/phpunit/Import/TalkpageImportOperationTest.php:111
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:131
gerritbot added a subscriber: gerritbot.Jun 17 2015, 8:28 AM

Change 218841 had a related patch set uploaded (by Matthias Mullie):
Fix TalkpageImportOperationTest

https://gerrit.wikimedia.org/r/218841

gerritbot added a comment.Jun 17 2015, 12:25 PM

Change 218841 merged by jenkins-bot:
Fix TalkpageImportOperationTest

https://gerrit.wikimedia.org/r/218841

DannyH closed this task as Resolved.Jun 18 2015, 5:34 PM
DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-D-2015-06-30 board.
DannyH added a subscriber: DannyH.
gerritbot added a comment.Jun 18 2015, 11:57 PM

Change 219287 had a related patch set uploaded (by EBernhardson):
Fix TalkpageImportOperationTest

https://gerrit.wikimedia.org/r/219287

gerritbot added a comment.Jun 19 2015, 12:01 AM

Change 219287 merged by jenkins-bot:
Fix TalkpageImportOperationTest

https://gerrit.wikimedia.org/r/219287

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL