Page MenuHomePhabricator

testImportDoesntCompletelyFail Flow test failing on Thanks changes
Closed, ResolvedPublic

Description

Thanks continuous integration PHPUnit tests are failing because of a Flow test, Flow\Tests\Import\TalkpageImportOperationTest::testImportDoesntCompletelyFail . See https://gerrit.wikimedia.org/r/#/c/184083/ .

Event Timeline

Mattflaschen-WMF raised the priority of this task from to High.
Mattflaschen-WMF updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2015, 7:47 PM

This seems to be intermittent. I was able to merge https://gerrit.wikimedia.org/r/218681 just fine, but https://gerrit.wikimedia.org/r/#/c/218683/1 failed due to this bug.

18:51:39 There was 1 error:
18:51:39 
18:51:39 1) Flow\Tests\Import\TalkpageImportOperationTest::testImportDoesntCompletelyFail
18:51:39 Flow\Exception\PermissionException: Formatting for wrong user: 127.0.0.1 instead of UTSysop
18:51:39 
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/Block/Block.php:152
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/Block/Header.php:58
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/View.php:56
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/Content/BoardContent.php:192
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/includes/page/WikiPage.php:2115
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/includes/page/WikiPage.php:1756
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/TalkpageManager.php:159
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/includes/Import/Importer.php:544
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/tests/phpunit/Import/TalkpageImportOperationTest.php:111
18:51:39 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:131

Change 218841 had a related patch set uploaded (by Matthias Mullie):
Fix TalkpageImportOperationTest

https://gerrit.wikimedia.org/r/218841

Change 218841 merged by jenkins-bot:
Fix TalkpageImportOperationTest

https://gerrit.wikimedia.org/r/218841

DannyH closed this task as Resolved.Jun 18 2015, 5:34 PM
DannyH added a subscriber: DannyH.

Change 219287 had a related patch set uploaded (by EBernhardson):
Fix TalkpageImportOperationTest

https://gerrit.wikimedia.org/r/219287

Change 219287 merged by jenkins-bot:
Fix TalkpageImportOperationTest

https://gerrit.wikimedia.org/r/219287