Page MenuHomePhabricator
Create Task
Maniphest T86827

[Regression] __STATICREDIRECT__ is set when user sets a redirect, regardless whether the user ticks the box to set it
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Go to Wikipedia (not Beta labs).
  1. Open a page
  1. Set a redirect, e.g., to [[Test]]. Do NOT tick the box to set STATICREDIRECT.
  1. Save the page.
  1. Check your diff, and find that STATICREDIRECT has been set anyway.

I couldn't reproduce this on beta labs this morning, so it's probable that the patch already exists and just needs to be ported to the production projects.

Details

SubjectRepoBranchLines +/-
Don't add __STATICREDIRECT__ whenever the user sets up redirect detailsmediawiki/extensions/VisualEditorwmf/1.25wmf15+3 -3
Don't add __STATICREDIRECT__ whenever the user sets up redirect detailsmediawiki/extensions/VisualEditorwmf/1.25wmf14+3 -3
Don't add __STATICREDIRECT__ whenever the user sets up redirect detailsmediawiki/extensions/VisualEditormaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Jan 14 2015, 8:48 PM
• Whatamidoing-WMF raised the priority of this task from to High.
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF added a project: VisualEditor.
• Whatamidoing-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2015, 8:48 PM
Jdforrester-WMF renamed this task from STATICREDIRECT should not be set when the user does not tick the box to set it to [Regression] __STATICREDIRECT__ is set when user sets a redirect, regardless whether the user does ticked the box to set it.Jan 15 2015, 12:18 AM
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.
gerritbot added a project: Patch-For-Review.Jan 19 2015, 11:34 PM
gerritbot subscribed.

Change 185930 had a related patch set uploaded (by Alex Monk):
Don't add STATICREDIRECT whenever the user sets up redirect details

https://gerrit.wikimedia.org/r/185930

Patch-For-Review

gerritbot added a comment.Jan 20 2015, 1:09 AM

Change 185930 merged by jenkins-bot:
Don't add STATICREDIRECT whenever the user sets up redirect details

https://gerrit.wikimedia.org/r/185930

Krenair mentioned this in rEVEDd94c25a5b120: Don't add __STATICREDIRECT__ whenever the user sets up redirect details.Jan 20 2015, 1:09 AM
gerritbot added a comment.Jan 20 2015, 4:49 PM

Change 185991 had a related patch set uploaded (by Jforrester):
Don't add STATICREDIRECT whenever the user sets up redirect details

https://gerrit.wikimedia.org/r/185991

Patch-For-Review

gerritbot added a comment.Jan 20 2015, 4:49 PM

Change 185992 had a related patch set uploaded (by Jforrester):
Don't add STATICREDIRECT whenever the user sets up redirect details

https://gerrit.wikimedia.org/r/185992

Patch-For-Review

Jdforrester-WMF renamed this task from [Regression] __STATICREDIRECT__ is set when user sets a redirect, regardless whether the user does ticked the box to set it to [Regression] __STATICREDIRECT__ is set when user sets a redirect, regardless whether the user ticks the box to set it.Jan 20 2015, 4:49 PM
Jdforrester-WMF assigned this task to Krenair.Jan 20 2015, 5:03 PM
Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.
gerritbot added a comment.Jan 20 2015, 7:57 PM

Change 185992 merged by jenkins-bot:
Don't add STATICREDIRECT whenever the user sets up redirect details

https://gerrit.wikimedia.org/r/185992

Jdforrester-WMF mentioned this in rEVEDad135d8ffc61: Don't add __STATICREDIRECT__ whenever the user sets up redirect details.Jan 20 2015, 7:57 PM
gerritbot added a comment.Jan 20 2015, 7:58 PM

Change 185991 merged by jenkins-bot:
Don't add STATICREDIRECT whenever the user sets up redirect details

https://gerrit.wikimedia.org/r/185991

Jdforrester-WMF mentioned this in rEVEDb537f70ccb13: Don't add __STATICREDIRECT__ whenever the user sets up redirect details.Jan 20 2015, 7:58 PM
Krenair closed this task as Resolved.Jan 21 2015, 1:15 AM

This was merged to master, deployed, etc.

Jdforrester-WMF added projects: WMF-deploy-2015-01-14_(1.25wmf15), WMF-deploy-2015-01-07_(1.25wmf14), WMF-deploy-2015-02-04_(1.25wmf16).Jan 23 2015, 7:30 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jan 30 2015, 6:22 PM
Jdforrester-WMF edited a custom field.Feb 2 2015, 7:46 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:01 PM
RandomDSdevel awarded a token.Mar 5 2015, 7:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL