Page MenuHomePhabricator

'Tap here to expand' - the label should change when the section is expanded?
Closed, ResolvedPublic

Description

  1. Search for Digitalis
  2. Scroll to Footnotes section. The section has 'Tap here to expand'
  3. Tap and the section will be expanded, but the label still is displayed as 'Tap here to expand' - which is confusing.

Arguably, the arrow icon(like in Quick facts) will be enough without any additional explanation labels.

Screenshot_2015-01-14-15-52-38.png (1,080×1,920 px, 284 KB)

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova subscribed.
Etonkovidova renamed this task from 'Tap here to expand' - the label to 'Tap here to expand' - the label should change when the section is expanded?.Jan 15 2015, 12:28 AM
Deskana subscribed.

We can either get rid of the message completely, or we can reuse the one that was used for "Quick facts".

Change 207227 had a related patch set uploaded (by Niedzielski):
Hide caption on "tap to expand" table when open

https://gerrit.wikimedia.org/r/207227

Change 207227 merged by jenkins-bot:
Hide caption on "tap to expand" table when open

https://gerrit.wikimedia.org/r/207227

@Niedzielski The tablet screenshots looks great.
If it looks exactly like this for a mobile phone then we are good to go. Please confirm.

@Vibhabamba, yep, it's intended to appear the same on all devices. Here's a shot on the Nexus 5:

2015-04-30-16-49-54-129461370.png (977×1,748 px, 537 KB)

@Niedzielski

Thanks! 2 Comments:

The grey tap area doesn't seem finger friendly.
It should be at least 45 px in height, so a user can tap on it without hitting other links.

25 px padding is needed between the grey header (carrying the close chevron) and the content inside it.

Kindly iterate and attach mocks if you can.

@Vibhabamba, sorry, not yet. Trying to wrap up another card but will get to this as soon as I can.

@Vibhabamba, see how you like this. It should look exactly the same in both collapsed and opened states except the text is only present in collapsed.

2015-05-02-00-48-15-296810766.png (977×1,748 px, 483 KB)

2015-05-02-00-44-20-438279730.png (977×1,748 px, 485 KB)

Change 208368 had a related patch set uploaded (by Niedzielski):
Increase "tap to expand" click area

https://gerrit.wikimedia.org/r/208368

Change 208368 merged by jenkins-bot:
Increase "tap to expand" click area

https://gerrit.wikimedia.org/r/208368