They should be unifiable now with some hiera magic.
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| operations/puppet | production | +9 -32 | deployment: Unify salt_masters role for prod / labs |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T53494 Use Beta cluster as a true canary for code deployments (epic) | |||
| Open | None | T87220 Minimize infrastructure differences between Beta Cluster and production | |||
| Resolved | • yuvipanda | T86644 Remove all ::beta roles in puppet | |||
| Resolved | • yuvipanda | T86885 Unify labs and prod roles for role::deployment::deployment_servers |
Event Timeline
Comment Actions
Change 185137 had a related patch set uploaded (by Yuvipanda):
deployment: Unify salt_masters role for prod / labs
Comment Actions
Change 185137 merged by Yuvipanda:
deployment: Unify salt_masters role for prod / labs
Comment Actions
There are some other use cases, we might want to fix them as well shouldn't we?
deployment_server_override:
$ git grep -n deployment_server_override manifests/role/deployment.pp:233: if ( $::deployment_server_override != undef ) { manifests/role/deployment.pp:234: $apache_fqdn = $::deployment_server_override manifests/role/trebuchet.pp:10: labs => pick($::deployment_server_override, "${::instanceproject}-deploy.eqiad.wmflabs"),
salt_master_override:
$ git grep -n salt_master.*override manifests/role/salt.pp:95: $master = pick($::salt_master_override, $labs_masters) manifests/role/salt.pp:96: $master_finger = pick($::salt_master_finger_override, $labs_finger)