Page MenuHomePhabricator

Unify labs and prod roles for role::deployment::deployment_servers
Closed, ResolvedPublic

Description

They should be unifiable now with some hiera magic.

Event Timeline

yuvipanda raised the priority of this task from to Needs Triage.
yuvipanda updated the task description. (Show Details)
yuvipanda added a subscriber: yuvipanda.
gerritbot added a subscriber: gerritbot.

Change 185137 had a related patch set uploaded (by Yuvipanda):
deployment: Unify salt_masters role for prod / labs

https://gerrit.wikimedia.org/r/185137

Patch-For-Review

greg triaged this task as Medium priority.Jan 29 2015, 5:37 PM
greg moved this task from To Triage to In-progress on the Beta-Cluster-Infrastructure board.

Change 185137 merged by Yuvipanda:
deployment: Unify salt_masters role for prod / labs

https://gerrit.wikimedia.org/r/185137

hashar added a subscriber: hashar.

There are some other use cases, we might want to fix them as well shouldn't we?

deployment_server_override:

$ git grep -n deployment_server_override
manifests/role/deployment.pp:233:    if ( $::deployment_server_override != undef ) {
manifests/role/deployment.pp:234:        $apache_fqdn = $::deployment_server_override
manifests/role/trebuchet.pp:10:        labs       => pick($::deployment_server_override, "${::instanceproject}-deploy.eqiad.wmflabs"),

salt_master_override:

$ git grep -n salt_master.*override
manifests/role/salt.pp:95:        $master        = pick($::salt_master_override, $labs_masters)
manifests/role/salt.pp:96:        $master_finger = pick($::salt_master_finger_override, $labs_finger)
yuvipanda claimed this task.

DDDONE. That was painful :)

See I3e947637b49ce2a94128e21db35798a49e8d45e8